Consider making SafeBrowsingDatabaseManager a pure virtual interface |
||||
Issue descriptionkmarshall hit some problems with the subresource filter FakeSafeBrowsingDatabaseManager actually being not a true fake, and it inherited some of the implementation's deletion thread affinity which was confusing and not necessary. Ideally, it would be nice for SafeBrowsingDatabaseManager itself to be a pure interface so our fake could implement it and be as simple as possible. Then the current SafeBrowsingDatabaseManager could be SafeBrowsingDatabaseManagerImpl or something like that.
,
Jun 26 2017
Yes I believe the issue was in destruction logic. We do already inherit from TestSafeBrowsingDatabaseManager for our fake implementation.
,
Jun 30 2017
,
Nov 10 2017
,
Feb 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nparker@chromium.org
, Jun 23 2017Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows