New issue
Advanced search Search tips

Issue 735588 link

Starred by 2 users
Status: Fixed
Owner:
alph@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

DevTools: Perf Flame Chart misrepresents H2 push

Project Member Reported by paulir...@chromium.org, Jun 21 2017 
See first attachment for the network waterfall of https://http2-server-push-demo.keksi.io/

The jpg is pushed right at the end of the HTML document.
However this "receiving push" time is lost in the flame chart.

We should definitely have a bar in the network section for this time. 
IMO it isn't important to have the blink-side network request on the same line.
Screen Shot 2017-06-21 at 11.44.02 AM.png
82.8 KB View Download
Screen Shot 2017-06-21 at 11.49.49 AM.png
67.3 KB View Download

Comment 1 by alph@chromium.org, Jul 7 2017

Labels: -Type-Bug Type-Feature
It does not misrepresent, it just doesn't show the push.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5ed187842d23ad31d3f86650bf260d421c7559b

commit a5ed187842d23ad31d3f86650bf260d421c7559b
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Jul 07 05:58:44 2017

DevTools: Show server push bars for timeline network requests.

Bug:  735588 
Change-Id: Ic10d10f09ee6c8f22c2d524b9e1a27972911a41b
Reviewed-on: https://chromium-review.googlesource.com/562654
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484843}
[modify] https://crrev.com/a5ed187842d23ad31d3f86650bf260d421c7559b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js
[modify] https://crrev.com/a5ed187842d23ad31d3f86650bf260d421c7559b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Comment 3 by alph@chromium.org, Jul 7 2017

Status: Fixed (was: Assigned)

Comment 4 by paulir...@chromium.org, Jul 7 2017 

Looks good!

https://http2.golang.org/serverpush is a fun site to test with. Found some weird cases here, like the push rectangle having -Infinity start, i guess?
long-push.json
2.4 MB View Download
Screen Shot 2017-07-07 at 3.12.01 PM.png
115 KB View Download
►

Sign in to add a comment