New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735585 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

WebUI: Remove paper-dropdown-menu from shipped binary.

Project Member Reported by dpa...@chromium.org, Jun 21 2017

Issue description

After addressing  crbug.com/720927 , there are no more usages of paper-dropdown-menu. We should remove it to reduce size and to prevent future usages of it.



 

Comment 1 by dpa...@chromium.org, Jun 21 2017

Cc: michae...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4da73c092149777b32b73e9b324d907ae2bc990e

commit 4da73c092149777b32b73e9b324d907ae2bc990e
Author: dpapad <dpapad@chromium.org>
Date: Fri Jun 23 18:45:21 2017

Polymer: Remove unused paper-dropdown-menu, paper-menu-button.

Also update reproduce.sh script to pass the --production flag to bower,
otherwise devDependencies are also pulled in.

BUG= 735585 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2947193002
Cr-Commit-Position: refs/heads/master@{#481969}

[modify] https://crrev.com/4da73c092149777b32b73e9b324d907ae2bc990e/third_party/polymer/v1_0/bower.json
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/compiled_resources2.gyp
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-icons.html
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light.html
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-shared-styles.html
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu.html
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-menu-button/bower.json
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-menu-button/compiled_resources2.gyp
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-animations-extracted.js
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-animations.html
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-extracted.js
[delete] https://crrev.com/49d85c9757fcbb563aafcfca3910572a032d8cd3/third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button.html
[modify] https://crrev.com/4da73c092149777b32b73e9b324d907ae2bc990e/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/4da73c092149777b32b73e9b324d907ae2bc990e/third_party/polymer/v1_0/reproduce.sh
[modify] https://crrev.com/4da73c092149777b32b73e9b324d907ae2bc990e/ui/webui/resources/polymer_resources.grdp

Comment 3 by dpa...@chromium.org, Jun 23 2017

Status: Fixed (was: Started)

Sign in to add a comment