New issue
Advanced search Search tips

Issue 735584 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Flame chart freakout on network request

Project Member Reported by paulir...@chromium.org, Jun 21 2017

Issue description

Load the saved trace into the perf panel

Witness as the bar for the HTML document changes its width dramatically as you zoom in.


 
sever-push-lol.json
2.7 MB View Download
networkbar.gif
467 KB View Download
higher frame rate helps :)
buggu.mov
1.9 MB Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d60d3ff28f638b077c9e315972e5e100b0060be

commit 4d60d3ff28f638b077c9e315972e5e100b0060be
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Jul 07 23:02:52 2017

DevTools: Fix timeline network bars flashing while drawing.

It was caused by the stale timeToPixel ratio during zoom animation. Request the actual
ratio from the chart viewport.

Bug:  735584 
Change-Id: I52a39c9377c9ae770a51e7f962426fc92dec8ec6
Reviewed-on: https://chromium-review.googlesource.com/562545
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485085}
[modify] https://crrev.com/4d60d3ff28f638b077c9e315972e5e100b0060be/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js
[modify] https://crrev.com/4d60d3ff28f638b077c9e315972e5e100b0060be/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Comment 3 by alph@chromium.org, Jul 8 2017

Status: Fixed (was: Assigned)

Sign in to add a comment