__cros_ec_pwm_get_duty using incorrect calling params |
||||||
Issue descriptionThe "cros/chromeos-4.4" linux kernel's __cros_ec_pwm_get_duty() routine in pwm-cros-ec.c was incorrectly setting the outsize field as insize and the insize field as outsize in the msg param block passed to cros_ec_cmd_xfer_status(). The original code still worked due to size of the two particular parameter blocks passed to cros_ec_cmd_xfer_status(), so this change is not fixing an actual runtime problem, just correcting the calling usage.
,
Jun 21 2017
,
Jun 21 2017
,
Jun 21 2017
,
Jun 27 2017
Patch has been sent upstream.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ef5b1bc5bcf9569c689183c3e67145c5cac10543 commit ef5b1bc5bcf9569c689183c3e67145c5cac10543 Author: Nick Vaccaro <nvaccaro@google.com> Date: Fri Jul 14 14:37:06 2017 UPSTREAM: pwm: cros-ec: Fix transposed param settings The __cros_ec_pwm_get_duty() routine was transposing the insize and outsize fields when calling cros_ec_cmd_xfer_status(). The original code worked without error due to size of the two particular parameter blocks passed to cros_ec_cmd_xfer_status(), so this change is not fixing an actual runtime problem, just correcting the calling usage. Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Thierry Reding <thierry.reding@gmail.com> (cherry picked from commit e47866a177cf0baba1d714fa93cb762f25bd6cef) BUG= chromium:735580 TEST=build on kevin, verify call works and causes no errors in ec Change-Id: Iebfdc70147a861756a44c76588ae2d298216e165 Reviewed-on: https://chromium-review.googlesource.com/570939 Commit-Ready: Nick Vaccaro <nvaccaro@chromium.org> Tested-by: Nick Vaccaro <nvaccaro@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/ef5b1bc5bcf9569c689183c3e67145c5cac10543/drivers/pwm/pwm-cros-ec.c
,
Jul 18 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nvaccaro@chromium.org
, Jun 21 2017