New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735550 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
isherman@chromium.org
█ jwd@chromium.org
treib@chromium.org
█ szhangcs@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Drop type="int" from enums.xml entries.

Project Member Reported by loonyb...@chromium.org, Jun 21 2017 
In the following two CLs, they included type attribute in <enum> in histograms/enums.xml. I believe this is a result of some automated script. Could some one please look into that?

Thanks 

https://chromium.googlesource.com/chromium/src/+/8a09a116476b0c45134ac2391e4768611c738ab8%5E%21/
https://chromium.googlesource.com/chromium/src/+/b0045cb0dec61387b7cc05049c2878b406bc298b

Comment 1 by isherman@chromium.org, Jun 22 2017

Cc: isherman@chromium.org
 Issue 735364  has been merged into this issue.

Comment 2 by isherman@chromium.org, Jun 22 2017 

The type attribute used to be required, and I recently dropped support for it.  Looks like those two CLs snuck in without re-running the "git cl format" presubmit :(

Comment 3 by isherman@chromium.org, Jun 22 2017

Status: Fixed (was: Untriaged)
Summary: Drop type="int" from enums.xml entries. (was: Some sync script is generating bug in histograms/enums.xml)
This seems to be fixed at ToT, btw.
►

Sign in to add a comment