New issue
Advanced search Search tips

Issue 735542 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 710660
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: Avatar icon grid not pre-populated with currently selected icon.

Project Member Reported by dpa...@chromium.org, Jun 21 2017

Issue description

Discovered this issue as part of fixing related  issue 734789 .

The currently selected profile icon is a data URI (don't know why). The available icons are chrome://theme URLs, see sceenshot.

The code to pre-poulate the grid with the currently selected icon (see [1], [2]) clearly assumes that it should be one of the available icons, therefore no icon is pre-selected.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.html?l=280
[2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/manage_profile.html?l=37

Note: This used to work in old Options, so need to investigate what changed.

+tommycli,mahmadi: It seems to me that this never actually worked, any help appreciated.  This is getting on my way for  issue 734789  (https://codereview.chromium.org/2950943002) since we have tests that seemingly test this functionality, but in the tests the data is always consistent unlike prod.
 
current_avatar_not_preselected.png
213 KB View Download

Comment 1 by dpa...@chromium.org, Jun 21 2017

Mergedinto: 710660
Status: Duplicate (was: Available)
Looking at the C++ code found a reference to the reason this is broken at https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/profile_info_handler.cc?l=197.

Sign in to add a comment