Fuchsia no longer returns '..' when iterating directories |
||
Issue descriptionAfter https://fuchsia.googlesource.com/magenta/+/2db38e2b99162c84ae43d39715031d59fcee7ac5 When this rolls in, it causes FileUtilTest.FileEnumeratorTest to fail because '..' isn't returned by readdir(). I think this would probably break the UI in https://cs.chromium.org/chromium/src/net/base/directory_lister.cc?rcl=84dc05fd513e3c4e7aa64f5dba954f8d0a641939&l=130 and maybe https://cs.chromium.org/chromium/src/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc?rcl=164abed19ba6d4882dc3b66028bcbfd24399b177&l=209 (though that's probably not relevant for Fuchsia) INCLUDE_DOT_DOT is pretty lightly used.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97 commit 1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97 Author: Scott Graham <scottmg@chromium.org> Date: Wed Jun 21 21:07:29 2017 Roll Fuchsia SDK to 457adecd1600ab82efa6d142cc506560b7d8f7c8 Follows https://bugs.chromium.org/p/chromium/issues/detail?id=707030#c4. Notable changes: - Includes https://fuchsia-review.googlesource.com/c/35564/ which makes futime[n]s() work, except that access time is not supported on Fuchsia (see linked bug). So FileUtilTest.TouchFile mostly works now. - Includes https://fuchsia.googlesource.com/magenta/+/2db38e2b99162c84ae43d39715031d59fcee7ac5 which removes '..' from readdir() (see other linked bug). For this case, update FileEnumerator to include a fake .. to preserve the interface expected for INCLUDE_DOT_DOT. This is necessary to keep FileUtilTest.FileEnumeratorTest working. (yay! caught a semi- regression) Bug: 706592, 735233 , 735540 Change-Id: Iafbd0f80ef386c2def9edd5be3e309b034cdf215 Reviewed-on: https://chromium-review.googlesource.com/542945 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#481293} [modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/DEPS [modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/base/files/file_enumerator_posix.cc [modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/base/files/file_util_unittest.cc [modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/testing/buildbot/filters/fuchsia.base_unittests.filter
,
Jun 22 2017
Fixed sufficiently on Chrome-side for base_unittests at least. |
||
►
Sign in to add a comment |
||
Comment 1 by smklein@google.com
, Jun 21 2017