Issue metadata
Sign in to add a comment
|
Unprefix -webkit-line-break |
||||||||||||||||||||||||||||||||||||||||||||
Issue descriptionBackground from kojii@ back in March: > Trident/Edge has unprefixed "line-break" for more than a decade, and WebKit recently unprefixed. It was working incorrectly but I fixed that, so it's just to add the unprefixed version and leave prefixed version for a while. > One complex thing is that it supports webkit-specific, non-standard value, -webkit-break-after-white-space. This one needs to be taken care of by the collaboration of the editing and the layout team, and we can't remove the prefixed version until it's done. So you might need to make "line-break" to accept only standard values, while "-webkit-line-break" to accept the non-standard value too. https://drafts.csswg.org/css-text-3/#line-break-property
,
Jun 25 2017
,
Jun 27 2017
,
Jun 27 2017
Wait, it says it works without prefix, and it does seem to work in stable 58.0.3029.110. But CSSProperties.json5 is:
{
name: "line-break",
alias_for: "-webkit-line-break",
runtime_flag: "CSSLineBreak",
},
and RuntimeEnabledFeatures.json5 is:
{
name: "CSSLineBreak",
status: "test",
},
...so I guess "runtime_flag" doesn't work for alias?
,
Jun 28 2017
Eddy confirmed that we have shipped this: https://groups.google.com/a/chromium.org/d/msg/style-dev/uzUmvT7vIO8/dIXuip4OAgAJ So I guess we should go post facto intent-to-ship process.
,
Jun 28 2017
,
Jun 28 2017
,
Jun 28 2017
Alright! I didn't know at first what runtime_flag was supposed to do, so I didn't know it was. I know this is not related to this bug now, but I'm wondering, is the next step to disallow use of "after-white-space" for "line-break"? Also, it looks like line-break doesn't work as intended currently, is that right? Looking at http://wpt.fyi/, it appears that all of the web-platform-tests css/css-text-3/line-break tests fail in both Chrome and Firefox. Is that right? In my example test (attached), it looks like English text is breaking after the ellipsis character (…) even when "-webkit-line-break: after-white-space" is applied, which is not what I expected. If "after-white-space" doesn't actually work right now, then it seems like removing it won't break anybody's website...
,
Jun 28 2017
> is the next step to disallow use of "after-white-space" for "line-break"? Yeah, it's something we need to work on. That one is probably the hardest one though. > Also, it looks like line-break doesn't work as intended currently, is that right? Looking at http://wpt.fyi/, it appears that all of the web-platform-tests css/css-text-3/line-break tests fail in both Chrome and Firefox. Is that right? This site shows only 12 tests when I type "text-line-break", so it's probably largely broken. Over 500 tests are there, all (or most?) are reftests. In our imported tests, we pass over 90% of over 500 tests, see blink-dev threads. > If "after-white-space" doesn't actually work right now, then it seems like removing it won't break anybody's website... It doesn't work as people expects, but it does something. Textarea and other editing features rely on its behavior. To see it, you can disable locally and run layout_tests, bunch will fail. My plan is to make editing work without this property, then, I agree, I hope sites do not rely too much on this.
,
Jun 28 2017
Or, if we also run only 12 tests today, that's a problem. When tests were in csswg-tests, I'm quite sure we were running 500 tests.
,
Jun 28 2017
We're running more than 12, but that site currently truncates to only 10 tests when there are more than 10 match results. If you type in more (e.g. "css/css-text-3/line-break/line-break-strict") then you get more specific results. (That site is currently under development so the UI isn't very well-refined...)
,
Jun 28 2017
I see. Files in the directory are old ones, I don't remember. There are 500 good tests in css/css-text-3/i18n/ and we pass 90% of them.
,
Jun 28 2017
By the way, thanks for the explanation and for making the shipping of line-break official :-)
,
Jun 29 2017
,
Jul 19 2017
Post-facto Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RHeWSxMIVK8/g5NJgZo9AQAJ Set Launch-M-Target to M59, though it has shipped in M58. See the Intent-to-ship for more details. Non-standard value (after-white-space) was removed from unprefixed version in issue 738593 .
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8e4785c70c9a30a149c2cc0cf97eb4b80d9f7ba commit d8e4785c70c9a30a149c2cc0cf97eb4b80d9f7ba Author: Koji Ishii <kojii@chromium.org> Date: Thu Sep 14 16:06:45 2017 CSS: Retire runtime flag CSSLineBreak The runtime flag is no longer needed. This runtime flag was added to import wpt[1], then shipped in M58. See crbug.com/735539 for more details of the ship. [1] https://codereview.chromium.org/2725543002 Bug: 306730 , 735539 Change-Id: I8442735a73db8729b21de3dc3166858e93ce9274 Reviewed-on: https://chromium-review.googlesource.com/664938 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#501963} [modify] https://crrev.com/d8e4785c70c9a30a149c2cc0cf97eb4b80d9f7ba/third_party/WebKit/Source/platform/runtime_enabled_features.json5 |
|||||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by bugsnash@chromium.org
, Jun 21 2017