New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735502 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Replace Current chevron with the one from the spec

Project Member Reported by newcomer@chromium.org, Jun 21 2017

Issue description

Replace the chevron in the peeking launcher view with the one from the spec.
 

Comment 1 by zalcorn@google.com, Jun 23 2017

Status: Assigned (was: Untriaged)
Owner: weidongg@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f4af3584484510a05497d4f63d1194a6f553d7

commit c6f4af3584484510a05497d4f63d1194a6f553d7
Author: weidongg <weidongg@chromium.org>
Date: Tue Jun 27 22:47:20 2017

Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG= 735502 

Review-Url: https://codereview.chromium.org/2959943003
Cr-Commit-Position: refs/heads/master@{#482767}

[modify] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/BUILD.gn
[modify] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/vector_icons/BUILD.gn
[add] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/vector_icons/ic_arrow_up.1x.icon
[add] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/vector_icons/ic_arrow_up.icon
[add] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/views/expand_arrow_view.cc
[add] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/views/expand_arrow_view.h
[modify] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/views/start_page_view.h
[modify] https://crrev.com/c6f4af3584484510a05497d4f63d1194a6f553d7/ui/app_list/views/suggestions_container_view.cc

Labels: NewLauncherUIV1
Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffbc4fd6a0c2561d40ce890f20975737a7f1262d

commit ffbc4fd6a0c2561d40ce890f20975737a7f1262d
Author: benwells <benwells@chromium.org>
Date: Wed Jun 28 04:04:25 2017

Revert of Replace AllAppsTileItemView with ArrowExpandView (patchset #2 id:20001 of https://codereview.chromium.org/2959943003/ )

Reason for revert:
Causes memory leak on ASAN LSAN bot, see
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/22001

Original issue's description:
> Replace AllAppsTileItemView with ArrowExpandView
>
> This CL replace the old "All apps" button in start page with a new arrow
> expand button.
>
> specs:
> https://screenshot.googleplex.com/PM0rC5nzVvE
> https://screenshot.googleplex.com/Qs1T3mHSf2D
>
> screenshot:
> https://screenshot.googleplex.com/RNQS0joM35z
>
> BUG= 735502 
>
> Review-Url: https://codereview.chromium.org/2959943003
> Cr-Commit-Position: refs/heads/master@{#482767}
> Committed: https://chromium.googlesource.com/chromium/src/+/c6f4af3584484510a05497d4f63d1194a6f553d7

TBR=xiyuan@chromium.org,weidongg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 735502 

Review-Url: https://codereview.chromium.org/2960123002
Cr-Commit-Position: refs/heads/master@{#482875}

[modify] https://crrev.com/ffbc4fd6a0c2561d40ce890f20975737a7f1262d/ui/app_list/BUILD.gn
[modify] https://crrev.com/ffbc4fd6a0c2561d40ce890f20975737a7f1262d/ui/app_list/vector_icons/BUILD.gn
[delete] https://crrev.com/98e73ca3ce9df57a64b32d83059674a906165dc4/ui/app_list/vector_icons/ic_arrow_up.1x.icon
[delete] https://crrev.com/98e73ca3ce9df57a64b32d83059674a906165dc4/ui/app_list/vector_icons/ic_arrow_up.icon
[delete] https://crrev.com/98e73ca3ce9df57a64b32d83059674a906165dc4/ui/app_list/views/expand_arrow_view.cc
[delete] https://crrev.com/98e73ca3ce9df57a64b32d83059674a906165dc4/ui/app_list/views/expand_arrow_view.h
[modify] https://crrev.com/ffbc4fd6a0c2561d40ce890f20975737a7f1262d/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/ffbc4fd6a0c2561d40ce890f20975737a7f1262d/ui/app_list/views/start_page_view.h
[modify] https://crrev.com/ffbc4fd6a0c2561d40ce890f20975737a7f1262d/ui/app_list/views/suggestions_container_view.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c24da4cdb9052839e6baf3291bd55436981b7b4

commit 7c24da4cdb9052839e6baf3291bd55436981b7b4
Author: weidongg <weidongg@chromium.org>
Date: Wed Jun 28 19:44:30 2017

Reland: Replace AllAppsTileItemView with ArrowExpandView

This CL replace the old "All apps" button in start page with a new arrow
expand button.

specs:
https://screenshot.googleplex.com/PM0rC5nzVvE
https://screenshot.googleplex.com/Qs1T3mHSf2D

screenshot:
https://screenshot.googleplex.com/RNQS0joM35z

BUG= 735502 

Review-Url: https://codereview.chromium.org/2959943003
Cr-Commit-Position: refs/heads/master@{#483103}

[modify] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/BUILD.gn
[modify] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/vector_icons/BUILD.gn
[add] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/vector_icons/ic_arrow_up.1x.icon
[add] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/vector_icons/ic_arrow_up.icon
[add] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/views/expand_arrow_view.cc
[add] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/views/expand_arrow_view.h
[modify] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/views/start_page_view.h
[modify] https://crrev.com/7c24da4cdb9052839e6baf3291bd55436981b7b4/ui/app_list/views/suggestions_container_view.cc

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment