Add X button in search bar with active query |
||||||
Issue descriptionAdd x button that replaces the voice search button when there is an active query. When clicked the search bar empties and the cursor is active with placeholder text aligned left. X button also needs ripple effect. Needed for Dogfooding.
,
Jun 26 2017
,
Jun 27 2017
,
Jul 7 2017
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4d19c5176595dd7b5def18ad8226cfe4c18bfa7 commit d4d19c5176595dd7b5def18ad8226cfe4c18bfa7 Author: Weidong Guo <weidongg@chromium.org> Date: Fri Jul 14 01:08:18 2017 Add X button in search bar with active query Changes: 1. Add X button in search box view. 2. Replace speech button with X button when the search box is active. 3. When X button is clicked, clear query in search box. Screenshot:https://screenshot.googleplex.com/aNdmi8pgqFD Specs: https://screenshot.googleplex.com/TX3rT2XXW3f BUG= 735499 TEST=app_list_unittests --gtest_filter='SearchBoxViewTest.CloseButtonTest' Change-Id: I60490d2b9bfbabf573f66d372cd98c70a95ac787 Reviewed-on: https://chromium-review.googlesource.com/568225 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#486577} [modify] https://crrev.com/d4d19c5176595dd7b5def18ad8226cfe4c18bfa7/ui/app_list/vector_icons/BUILD.gn [add] https://crrev.com/d4d19c5176595dd7b5def18ad8226cfe4c18bfa7/ui/app_list/vector_icons/ic_close.1x.icon [add] https://crrev.com/d4d19c5176595dd7b5def18ad8226cfe4c18bfa7/ui/app_list/vector_icons/ic_close.icon [modify] https://crrev.com/d4d19c5176595dd7b5def18ad8226cfe4c18bfa7/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/d4d19c5176595dd7b5def18ad8226cfe4c18bfa7/ui/app_list/views/search_box_view.h [modify] https://crrev.com/d4d19c5176595dd7b5def18ad8226cfe4c18bfa7/ui/app_list/views/search_box_view_unittest.cc
,
Jul 27 2017
,
Aug 1 2017
Verified on Chrome OS 9765.13.0, 61.0.3163.20 (dev build). |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by zalcorn@google.com
, Jun 23 2017