New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735497 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Email to this user bounced
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Out-of-memory in angle_translator_fuzzer

Project Member Reported by ClusterFuzz, Jun 21 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4792987287814144

Fuzzer: libFuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Out-of-memory (exceeds 2048 MB)
Crash Address: 
Crash State:
  angle_translator_fuzzer
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=478644:478700

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4792987287814144


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 28 2017

Labels: OS-Mac
Labels: Pri-2
Stack-overflow, Out of memory and Timeout issues are 'P2'.
Cc: msrchandra@chromium.org
Labels: Needs-Feedback
As this being an Out of memory issue, can this issue be marked as Won't Fix. Could some one please look into the issue and provide and update.
Thank You.
Labels: -Needs-Feedback
Status: WontFix (was: Untriaged)
Marking the issue as Wont Fix as this is an Out of Memory issue.
Thank You.

Comment 5 by mmoroz@chromium.org, Sep 30 2017

Status: Unconfirmed (was: WontFix)
Re-opening the issue, as it has been incorrectly closed as WontFix. Out of Memory issues are valid bugs in most of the cases.

WontFix status might be assigned only by the owner of the target code, if there is no way or no reason to prevent fuzzer from causing OOM crash.

Sometimes we mark OOMs found with MSan as WontFix because MSan has big memory overhead. However, that should not be done without a proper understanding of the target as well as without looking at the crash stats.
Cc: cwallez@chromium.org pnangunoori@chromium.org jmad...@chromium.org
Components: Internals>GPU>ANGLE
Labels: Test-Predator-Wrong
Owner: oetu...@nvidia.com
Status: Assigned (was: Unconfirmed)
As per the  Issue 765965  owner, assigning this issue to @oetuaho.
@oetuaho-- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Thanks.

Comment 7 by oetu...@nvidia.com, Oct 9 2017

It seems like most of the memory use comes from AST representation of the code that's used to initialize a large array in the shader code to zero. Arrays have to be initialized one element at a time due to limitations of GLSL ES 1.00, which creates a lot of code for large arrays.

This could be optimized by at least the following alternative ways:
1. By initializing arrays using a loop instead. Constant-duration for loops are allowed in GLSL ES 1.00.
2. By not duplicating strings in TIntermSymbol nodes in memory, instead storing symbol strings in a central location indexed by the symbol id.

The first alternative is pretty easy to implement, so I'll try to make a patch for that. The only concern is possibly exposing HW/driver-related bugs, as we've already had some weird ones in the past like  http://crbug.com/709317  .
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/180f43c6b39814e636b1ecabc8a41e6f18610577

commit 180f43c6b39814e636b1ecabc8a41e6f18610577
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Tue Oct 10 09:52:50 2017

Refactor creating temporary symbols

This makes creating temporary symbols easy also outside of traversers.
This will be needed for improving variable initialization.

TEST=angle_unittests
BUG= chromium:735497 

Change-Id: Id048fc338e0be6c76bb6f082421ae106618e5003
Reviewed-on: https://chromium-review.googlesource.com/707194
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/180f43c6b39814e636b1ecabc8a41e6f18610577/src/compiler/translator/IntermTraverse.cpp
[modify] https://crrev.com/180f43c6b39814e636b1ecabc8a41e6f18610577/src/compiler/translator/IntermTraverse.h
[modify] https://crrev.com/180f43c6b39814e636b1ecabc8a41e6f18610577/src/compiler/translator/IntermNode_util.cpp
[modify] https://crrev.com/180f43c6b39814e636b1ecabc8a41e6f18610577/src/compiler/translator/IntermNode_util.h

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/874d8aef9acc40ffacb68ae2c8c897ab1b112a49

commit 874d8aef9acc40ffacb68ae2c8c897ab1b112a49
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Tue Oct 10 10:58:02 2017

Roll skia/third_party/externals/angle2/ d63d0007c..180f43c6b (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/d63d0007c119..180f43c6b398

$ git log d63d0007c..180f43c6b --date=short --no-merges --format='%ad %ae %s'
2017-10-09 oetuaho Refactor creating temporary symbols

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 735497 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=reed@google.com

Change-Id: I06fd36db77e5d51103c491eda49f653d289eab0a
Reviewed-on: https://skia-review.googlesource.com/57500
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/874d8aef9acc40ffacb68ae2c8c897ab1b112a49/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e36f9b1af56c5e6bf58fa54ea30d017b1e191ef

commit 2e36f9b1af56c5e6bf58fa54ea30d017b1e191ef
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Tue Oct 10 14:36:50 2017

Roll src/third_party/skia/ 16e92cdd9..b6c5e5b95 (25 commits)

https://skia.googlesource.com/skia.git/+log/16e92cdd91bd..b6c5e5b956af

$ git log 16e92cdd9..b6c5e5b95 --date=short --no-merges --format='%ad %ae %s'
2017-10-09 halcanary DM: move skiatest functions into separate file.
2017-10-09 fmalita [SVGDom] Fix href handling for radial gradients
2017-10-10 angle-deps-roller Roll skia/third_party/externals/angle2/ d63d0007c..180f43c6b (1 commit)
2017-10-09 angle-deps-roller Roll skia/third_party/externals/angle2/ 359487c82..d63d0007c (1 commit)
2017-10-09 benjaminwagner Revert "Revert "Fix a couple float-cast-overflow in SkScan*.""
2017-10-09 bungeman Small pathops cleanup.
2017-10-09 bungeman Remove trailing whitespace.
2017-10-09 agable Remove references to Rietveld from skia's presubmit
2017-10-09 bungeman Remove carriage returns.
2017-10-09 fmalita [SVGDom] Radial gradient support
2017-10-09 bsalomon Revert "Revert "Disable GL buffer mapping on TSAN/Mac.""
2017-10-09 kjlubick Add Linux CPU Coverage Bot
2017-10-09 fmalita [SVGDom] Factor out common gradient logic
2017-10-09 caryclark first cut at SkRect, SkIRect documentation
2017-10-09 djsollen Reduce the frequency of the text atlas compaction.
2017-10-09 ivafanas fix use of uninitialized flag in SkCodec
2017-10-09 benjaminwagner Cleanup jobs.
2017-10-09 csmartdalton Revert "Enable coverage counting path rendering except on Android framework"
2017-10-09 reed use unsigned to allow for using all 32bits for approx distance
2017-10-09 reed fix include guard
2017-10-09 robertphillips Disable deferred proxies a different way in Chrome
2017-10-09 reed remove legacy computeByteSize flag, now returns max_size_t
2017-10-09 reed use new computeByteSize api
2017-10-09 benjaminwagner Revert "Fix a couple float-cast-overflow in SkScan*."
2017-10-09 reed Revert "Revert "change computeByteSize to return max_size_t on overflow""

Created with:
  roll-dep src/third_party/skia
BUG= 735497 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I5f4c3e708af5b679509aa4c163f5faf102eb7e1e
Reviewed-on: https://chromium-review.googlesource.com/709074
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507663}
[modify] https://crrev.com/2e36f9b1af56c5e6bf58fa54ea30d017b1e191ef/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df36684e0b2cc8c8e2004fe738ee798b58559511

commit df36684e0b2cc8c8e2004fe738ee798b58559511
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Oct 10 18:16:14 2017

Roll ANGLE 000dab8..af5070f

https://chromium.googlesource.com/angle/angle.git/+log/000dab8..af5070f

BUG=chromium:675997, chromium:743136 , chromium:735497 

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I12dc98d7721a04f3e3ff45dff571f4f297bff695
Reviewed-on: https://chromium-review.googlesource.com/709468
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507721}
[modify] https://crrev.com/df36684e0b2cc8c8e2004fe738ee798b58559511/DEPS

For more information, please see https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md.

The link referenced in the description is no longer valid.

(bulk edit)
Cc: oetu...@nvidia.com
 Issue 765965  has been merged into this issue.
There's a candidate patch for fixing this here:

https://chromium-review.googlesource.com/c/angle/angle/+/739826

but it's hitting a platform bug on Android. Could look into combining the fix with a workaround for Android.
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/bb0775da28e3305ef0466f3542a60e3559aaf79f

commit bb0775da28e3305ef0466f3542a60e3559aaf79f
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Sun Nov 12 09:08:00 2017

Add flag for turning off initializing variables with loops

This flag is needed to toggle upcoming variable initialization mode
which uses for loops to optimize the compilation process. Initializing
variables using for loops will be turned on by default, but it needs
to be turned off in Chromium in certain cases. Chromium will use the
flag added in this patch and that code will need to go into Chromium
before finishing the implementation in ANGLE.

BUG= chromium:735497 

Change-Id: I3a0e7b7c6cebe60afa72964fbd0caf3b1eafccbc
Reviewed-on: https://chromium-review.googlesource.com/763451
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/bb0775da28e3305ef0466f3542a60e3559aaf79f/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/bb0775da28e3305ef0466f3542a60e3559aaf79f/src/libANGLE/renderer/gl/WorkaroundsGL.h
[modify] https://crrev.com/bb0775da28e3305ef0466f3542a60e3559aaf79f/src/libANGLE/renderer/gl/ShaderGL.cpp
[modify] https://crrev.com/bb0775da28e3305ef0466f3542a60e3559aaf79f/include/GLSLANG/ShaderLang.h

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe2fef9fa3b31d3f966b476352c5f00830777934

commit fe2fef9fa3b31d3f966b476352c5f00830777934
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Sun Nov 12 10:28:05 2017

Roll src/third_party/angle/ 485903582..bb0775da2 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/485903582c25..bb0775da28e3

$ git log 485903582..bb0775da2 --date=short --no-merges --format='%ad %ae %s'
2017-11-10 oetuaho Add flag for turning off initializing variables with loops

Created with:
  roll-dep src/third_party/angle
BUG= 735497 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=None (channel is sheriff)@chromium.org

Change-Id: Iffdc0bfc7a66f161bfb80d6a4845f9f8834b2978
Reviewed-on: https://chromium-review.googlesource.com/764956
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515863}
[modify] https://crrev.com/fe2fef9fa3b31d3f966b476352c5f00830777934/DEPS

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/34922a64225ba62eaed82880538cde514a6fd61c

commit 34922a64225ba62eaed82880538cde514a6fd61c
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Sun Nov 12 20:29:40 2017

Roll skia/third_party/externals/angle2/ 3a9090fa0..703671e9f (9 commits)

https://chromium.googlesource.com/angle/angle.git/+log/3a9090fa0bfd..703671e9fddc

$ git log 3a9090fa0..703671e9f --date=short --no-merges --format='%ad %ae %s'
2017-11-08 oetuaho Unify extension behavior checks
2017-11-10 oetuaho Add flag for turning off initializing variables with loops
2017-11-07 jgilbert Remove formatType arg from computeCompressedImageSize.
2017-11-10 jmadill Optimize ShaderVariable::isBuiltIn.
2017-11-10 thomasanderson Add missing include to stddef.h on arm
2017-10-17 cwallez Use a packed enum for buffer targets.
2017-11-10 ynovikov Align float access in InterleavedAttributeData perf test
2017-11-09 jmadill Vulkan: Implement Buffer updates.
2017-09-13 yizhou.jiang Workaround Intel driver bug on D3D when renderering with no render target

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 735497 ,675997


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=brianosman@google.com

Change-Id: I3f1f4562db5d03660ab5cc7633689479f367307b
Reviewed-on: https://skia-review.googlesource.com/70482
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/34922a64225ba62eaed82880538cde514a6fd61c/DEPS

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a59fbd5d1ec44f6f814647f3a923269edbac6b

commit e8a59fbd5d1ec44f6f814647f3a923269edbac6b
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Sun Nov 12 22:08:30 2017

Roll src/third_party/skia/ 24e4cc708..34922a642 (2 commits)

https://skia.googlesource.com/skia.git/+log/24e4cc7087bc..34922a64225b

$ git log 24e4cc708..34922a642 --date=short --no-merges --format='%ad %ae %s'
2017-11-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 3a9090fa0..703671e9f (9 commits)
2017-11-12 brianosman Suppress warning 4577 (noexcept used with no exception handling mechanism specified)

Created with:
  roll-dep src/third_party/skia
BUG= 735497 ,675997


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I99d4906375ff3250578415f75c6a3e12ee871eb7
Reviewed-on: https://chromium-review.googlesource.com/765568
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515871}
[modify] https://crrev.com/e8a59fbd5d1ec44f6f814647f3a923269edbac6b/DEPS

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2aa042b03e5212439ac50ce76019f75e8d375c8

commit c2aa042b03e5212439ac50ce76019f75e8d375c8
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Tue Nov 14 22:28:33 2017

Set GLSL variable init not to use loops on Android

This will make it possible to enable using loops for variable
initialization inside ANGLE without triggering Android driver bugs.
Previously driver bugs were seen to cause failures in WebGL
conformance test deqp_data_gles2_shaders_functions on ANGLE Android
test bot.

BUG= chromium:735497 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I584bcb7d10ed484bf71111d98947783707221cce
Reviewed-on: https://chromium-review.googlesource.com/765970
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Cr-Commit-Position: refs/heads/master@{#516463}
[modify] https://crrev.com/c2aa042b03e5212439ac50ce76019f75e8d375c8/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/c2aa042b03e5212439ac50ce76019f75e8d375c8/gpu/config/gpu_driver_bug_list.json
[modify] https://crrev.com/c2aa042b03e5212439ac50ce76019f75e8d375c8/gpu/config/gpu_driver_bug_workaround_type.h

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b5601eb67596805dd1d98237915430ba733fa095

commit b5601eb67596805dd1d98237915430ba733fa095
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Thu Nov 16 20:14:54 2017

Only initialize globals if initialization flag is set

This avoids the possibility of initializing globals twice in Chromium.
Now we also never initialize variables redundantly in case we're
writing HLSL output. This was already the intent of the code before,
but a mistake had slipped in and the code didn't actually check the
output type properly.

This also simplifies DeferGlobalInitializers by running it after
SeparateDeclarations.

BUG= chromium:735497 
TEST=WebGL conformance tests

Change-Id: I95036a24ac8cf18113755510376a2fca286b3ee6
Reviewed-on: https://chromium-review.googlesource.com/771555
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/b5601eb67596805dd1d98237915430ba733fa095/src/compiler/translator/Compiler.cpp
[modify] https://crrev.com/b5601eb67596805dd1d98237915430ba733fa095/src/compiler/translator/DeferGlobalInitializers.cpp
[modify] https://crrev.com/b5601eb67596805dd1d98237915430ba733fa095/src/compiler/translator/TranslatorHLSL.h
[modify] https://crrev.com/b5601eb67596805dd1d98237915430ba733fa095/include/GLSLANG/ShaderLang.h
[modify] https://crrev.com/b5601eb67596805dd1d98237915430ba733fa095/src/compiler/translator/Compiler.h

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48633222cdc4af04df7bdefa16166be77df07070

commit 48633222cdc4af04df7bdefa16166be77df07070
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 17 04:31:29 2017

Roll src/third_party/angle/ a3106c585..784134994 (5 commits)

https://chromium.googlesource.com/angle/angle.git/+log/a3106c585ae6..784134994bd0

$ git log a3106c585..784134994 --date=short --no-merges --format='%ad %ae %s'
2017-11-16 ynovikov Skip ShaderStorageBufferTest31.AtomicMemoryFunctions on Linux AMD GL
2017-11-16 brandon1.jones Add Regression Test for D3D11 Alpha Passthrough
2017-11-15 oetuaho Only initialize globals if initialization flag is set
2017-11-14 jmadill Add perf test for ushort DrawElements.
2017-11-02 jgilbert Add TextureUploadFormatTest for texture unpack/upload behavior checks.

Created with:
  roll-dep src/third_party/angle
BUG= 735497 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ia86b64a7f93079eb2b4621174dca99eedf38221b
Reviewed-on: https://chromium-review.googlesource.com/775884
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517299}
[modify] https://crrev.com/48633222cdc4af04df7bdefa16166be77df07070/DEPS

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ecd62a6cf65ad2a3dcdad8decbe8677f5a74e02a

commit ecd62a6cf65ad2a3dcdad8decbe8677f5a74e02a
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 17 06:23:15 2017

Roll skia/third_party/externals/angle2/ 8957b6c07..1eda27a65 (4 commits)

https://chromium.googlesource.com/angle/angle.git/+log/8957b6c07125..1eda27a65489

$ git log 8957b6c07..1eda27a65 --date=short --no-merges --format='%ad %ae %s'
2017-11-16 jmadill Buffer11: Allow CopySubData from uninitialized.
2017-11-16 ynovikov Skip ShaderStorageBufferTest31.AtomicMemoryFunctions on Linux AMD GL
2017-11-16 brandon1.jones Add Regression Test for D3D11 Alpha Passthrough
2017-11-15 oetuaho Only initialize globals if initialization flag is set

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 735497 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=brianosman@google.com

Change-Id: I6379cf342ddcdfcd7cf0390c46da36ff4115ac4b
Reviewed-on: https://skia-review.googlesource.com/73123
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/ecd62a6cf65ad2a3dcdad8decbe8677f5a74e02a/DEPS

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa6418654df091f68dbcbc93ae71b3da5f344663

commit fa6418654df091f68dbcbc93ae71b3da5f344663
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Nov 17 08:50:29 2017

Roll src/third_party/skia/ 35c556f33..ecd62a6cf (1 commit)

https://skia.googlesource.com/skia.git/+log/35c556f33e2c..ecd62a6cf65a

$ git log 35c556f33..ecd62a6cf --date=short --no-merges --format='%ad %ae %s'
2017-11-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 8957b6c07..1eda27a65 (4 commits)

Created with:
  roll-dep src/third_party/skia
BUG= 735497 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I52a03d412fe4ff62fe83f98499a5be22bafc2afc
Reviewed-on: https://chromium-review.googlesource.com/776026
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517344}
[modify] https://crrev.com/fa6418654df091f68dbcbc93ae71b3da5f344663/DEPS

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/2c7f34c833b4a9ca4d016dbc55f1755f40826e6e

commit 2c7f34c833b4a9ca4d016dbc55f1755f40826e6e
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Fri Nov 17 11:12:00 2017

Initialize uninitialized GLSL arrays in a for loop

Previously, creating nodes for initializing each single array element
could result in memory bloat during translation when dealing with
large arrays. The resulting shader could also end up very long.
Initialize most arrays using a simple for loop instead. The loop is
compatible with ESSL 1.00 Appendix A limitations.

An exception is made for fragment outputs, so that they are not
indexed by non-constant values.

On some platforms using the a loop to initialize variables can cause
problems, so we also have a compiler flag for turning this behavior
off. The flag was already added earlier for a staggered rollout of
this functionality.

BUG= chromium:735497 
TEST=angle_unittests, angle_end2end_tests, WebGL conformance tests

Change-Id: Iec727821d8137db56b440ddbe007879b1b55f61f
Reviewed-on: https://chromium-review.googlesource.com/707195
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/2c7f34c833b4a9ca4d016dbc55f1755f40826e6e/src/compiler/translator/Compiler.cpp
[modify] https://crrev.com/2c7f34c833b4a9ca4d016dbc55f1755f40826e6e/src/compiler/translator/InitializeVariables.cpp
[modify] https://crrev.com/2c7f34c833b4a9ca4d016dbc55f1755f40826e6e/src/compiler/translator/DeferGlobalInitializers.cpp
[modify] https://crrev.com/2c7f34c833b4a9ca4d016dbc55f1755f40826e6e/src/compiler/translator/DeferGlobalInitializers.h
[modify] https://crrev.com/2c7f34c833b4a9ca4d016dbc55f1755f40826e6e/src/compiler/translator/InitializeVariables.h

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/3e4d1fde7fab46875cb70e23003b40aac262f0bc

commit 3e4d1fde7fab46875cb70e23003b40aac262f0bc
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 17 14:17:55 2017

Roll skia/third_party/externals/angle2/ 1eda27a65..2c7f34c83 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/1eda27a65489..2c7f34c833b4

$ git log 1eda27a65..2c7f34c83 --date=short --no-merges --format='%ad %ae %s'
2017-10-09 oetuaho Initialize uninitialized GLSL arrays in a for loop
2017-11-15 oetuaho Fix VectorizeVectorScalarArithmetic statement insertion

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 735497 , 784078 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=brianosman@google.com

Change-Id: Ie834dd9e0cb15bb5684ccd2a24c6fdc65e3c1d57
Reviewed-on: https://skia-review.googlesource.com/73063
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/3e4d1fde7fab46875cb70e23003b40aac262f0bc/DEPS

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eda055fb80e52bd7808e4e5c94755c0bd6e4f9c

commit 6eda055fb80e52bd7808e4e5c94755c0bd6e4f9c
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 17 15:38:52 2017

Roll src/third_party/angle/ bb27c3a14..2c7f34c83 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/bb27c3a1483c..2c7f34c833b4

$ git log bb27c3a14..2c7f34c83 --date=short --no-merges --format='%ad %ae %s'
2017-10-09 oetuaho Initialize uninitialized GLSL arrays in a for loop

Created with:
  roll-dep src/third_party/angle
BUG= 735497 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I7a25c9f6a48140ab7ed97cb8fb2ef3680c62ed54
Reviewed-on: https://chromium-review.googlesource.com/776642
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517402}
[modify] https://crrev.com/6eda055fb80e52bd7808e4e5c94755c0bd6e4f9c/DEPS

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25a01be78c40efe4d321a1961abf1dc82b67096

commit b25a01be78c40efe4d321a1961abf1dc82b67096
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Nov 17 17:56:33 2017

Roll src/third_party/skia/ 57e0828fa..3e4d1fde7 (2 commits)

https://skia.googlesource.com/skia.git/+log/57e0828fade9..3e4d1fde7fab

$ git log 57e0828fa..3e4d1fde7 --date=short --no-merges --format='%ad %ae %s'
2017-11-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 1eda27a65..2c7f34c83 (2 commits)
2017-11-17 scroggo Fix webp bug compositing alpha frames on opaque (better fix)

Created with:
  roll-dep src/third_party/skia
BUG= 735497 , 784078 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I1f45988b72e5268b343dd4f575c23bb0c8ed51fc
Reviewed-on: https://chromium-review.googlesource.com/776644
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517463}
[modify] https://crrev.com/b25a01be78c40efe4d321a1961abf1dc82b67096/DEPS

Project Member

Comment 28 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/87cc90dfaaf78e306eb4758bfdcb4c8977de4452

commit 87cc90dfaaf78e306eb4758bfdcb4c8977de4452
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Wed Dec 13 11:34:06 2017

Set proper precision on loop index for variable init

Previously the index variable was missing a precision. This may have
been behind loop-based init failing on some Android platforms.

BUG= chromium:735497 
TEST=angle_unittests

Change-Id: I0307891dfb2edf6c52efd5b495f602b380263d65
Reviewed-on: https://chromium-review.googlesource.com/822413
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/87cc90dfaaf78e306eb4758bfdcb4c8977de4452/src/compiler/translator/Compiler.cpp
[modify] https://crrev.com/87cc90dfaaf78e306eb4758bfdcb4c8977de4452/src/compiler/translator/InitializeVariables.cpp
[modify] https://crrev.com/87cc90dfaaf78e306eb4758bfdcb4c8977de4452/src/compiler/translator/DeferGlobalInitializers.cpp
[modify] https://crrev.com/87cc90dfaaf78e306eb4758bfdcb4c8977de4452/src/compiler/translator/DeferGlobalInitializers.h
[modify] https://crrev.com/87cc90dfaaf78e306eb4758bfdcb4c8977de4452/src/compiler/translator/InitializeVariables.h

Labels: -OS-Linux
Status: WontFix (was: Assigned)
WontFixing this so that we can have individual bugs for each fuzz target. Right now their crash state is NULL, see https://chrome-internal-review.googlesource.com/c/chrome/tools/clusterfuzz/+/568163 for fix.
Project Member

Comment 30 by ClusterFuzz, Feb 12 2018

Labels: OS-Linux

Sign in to add a comment