there is a small piece missing that normally only matters for WebView. There is a frameworks_XX jar file under
third_party/android_platform/webview/
this file contains system SDKs that WebView uses and we compile it from AOSP tree. Currently this file is still on Android N MR1 because android sources not released to AOSP yet.
So roll is not complete for Webview yet - using O APIs in Webview will fail, and afaik Michael already tried that. I don't know if this would impact monochrome or not.
We should go ahead and ask Android if it's okay to roll this publicly now; we need to be able to upstream the webview O changes ASAP to prevent there being a large time window when open source builds don't work.
Earlier today a patch which calls new O APIs managed to break the Android build, despite passing on all the trybots:
https://chromium-review.googlesource.com/c/536974/
I don't know exactly what happened there, but I guess I should wait with other changes that call O APIs until this bug is completely resolved and you've given the green light John? I assume there will be a PSA to chromium/clank-team?
(Itching to take out the reflection I added for Channels - draft CL here: https://chromium-review.googlesource.com/c/568026/ ..this code isn't called on WebView so I'm assuming it's fine from that perspective).
I'm a bit surprised that that CL failed in proguarding on that bot, though it looks like it failed while proguarding monochrome_public_apk, so perhaps that's related to the frameworks jar that's lagging behind.
While compiling system_webview_google_apk from scratch, I received a lot findbugs errors like this:
[47009/47053] ACTION //clank/android_webview/next:java__findbugs(//build/toolchain/android:android_clang_arm64)
I 0.003s Main [host]> java -classpath /usr/local/google/code/clankium/src/third_party/findbugs/lib/findbugs.jar: -Xmx768m '-Dfindbugs.home="/usr/local/google/code/clankium/src/third_party/findbugs"' -jar /usr/local/google/code/clankium/src/third_party/findbugs/lib/findbugs.jar -textui -sortByClass -pluginList /usr/local/google/code/clankium/src/tools/android/findbugs_plugin/lib/chromiumPlugin.jar -xml:withMessages -auxclasspath /usr/local/google/code/clankium/src/third_party/android_tools/sdk/platforms/android-23/android.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/android_webview/glue/glue.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/clank/java/content_next_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/android_webview/android_webview_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/android_webview/android_webview_commandline_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/android_webview/android_webview_platform_services_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/base/base_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/components/autofill/android/autofill_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/components/autofill/android/provider_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/content/public/android/content_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/net/android/net_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/ui/android/ui_full_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/ui/android/ui_utils_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/build/android/buildhooks/build_hooks_java.jar:/usr/local/google/code/clankium/src/out/Debug/lib.java/build/android/buildhooks/build_hooks_android_java.jar -exclude /usr/local/google/code/clankium/src/build/android/findbugs_filter/findbugs_exclude.xml -output gen/clank/android_webview/next/java__findbugs/result.xml /usr/local/google/code/clankium/src/out/Debug/lib.java/clank/android_webview/next/java.jar
D 6.033s Main The following errors occurred during analysis:
D 6.033s Main File not found: filesystem:/usr/local/google/code/clankium/src/third_party/android_tools/sdk/platforms/android-23/android.jar
D 6.033s Main The following classes needed for analysis were missing:
D 6.033s Main android.view.autofill.AutofillManager$AutofillCallback
D 6.033s Main android.webkit.RenderProcessGoneDetail
D 6.034s Main android.webkit.WebViewFactoryProvider
D 6.034s Main android.webkit.WebViewProvider
D 6.034s Main android.webkit.WebViewProvider$ScrollDelegate
D 6.034s Main android.webkit.WebViewProvider$ViewDelegate
D 6.034s Main android.graphics.Rect
D 6.034s Main android.util.SparseArray
D 6.034s Main android.webkit.WebViewDelegate
D 6.034s Main android.view.autofill.AutofillValue
D 6.034s Main android.content.Context
D 6.034s Main android.view.autofill.AutofillManager
D 6.034s Main android.webkit.WebView
D 6.034s Main android.webkit.WebView$PrivateAccess
D 6.034s Main android.view.textclassifier.TextClassifier
D 6.034s Main android.graphics.RectF
D 6.034s Main android.graphics.Matrix
D 6.034s Main android.view.ViewGroup
D 6.034s Main android.webkit.WebViewClient
D 6.034s Main android.view.ViewStructure
D 6.034s Main android.view.ViewStructure$HtmlInfo$Builder
D 6.034s Main android.view.autofill.AutofillId
D 6.034s Main android.view.ViewStructure$HtmlInfo
D 6.035s Main android.os.Parcelable
D 6.035s Main
D 6.035s Main Missing classes: 17
D 6.035s Main Analysis errors: 1
Basically findbugs is complaining that it can't find /android-23/android.jar, it won't stop compiling though.
This is because we haven't updated findbugs.py, it is using |constants.ANDROID_SDK_VERSION| which is |version_codes.MARSHMALLOW|, and which is 23. https://cs.chromium.org/chromium/src/build/android/pylib/utils/findbugs.py?q=findbugs+-f:third_party&sq=package:chromium&dr=CSs&l=117.
jbudorick@, seems you had a plan to update it?
Cc: sakal@chromium.org Status: Started (was: Fixed)
I still haven't landed the platform-tools update, so this isn't quite fixed yet. sakal@ has a CL up to do so: https://chromium-review.googlesource.com/c/615163
I'm landing a workaround in devil that should stabilize the main issue we know about w/ 1.0.39.
Comment 1 by jbudorick@chromium.org
, Jun 21 2017