New issue
Advanced search Search tips

Issue 735474 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: 2019-07-09
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

chrome watcher does not register dumpwithoutcrashing in base

Project Member Reported by wfh@chromium.org, Jun 21 2017

Issue description

I noticed while working on another CL that the watchermain (equivalent of chromemain) for chrome_watcher.dll does not register the dumpwithoutcrashing function with base::debug::SetDumpWithoutCrashingFunction

This would mean that calling base::debug::DumpWithoutCrashing for code running in chrome_watcher.dll would do nothing. I don't know the impact of this, since perhaps it never gets called.

Aside, perhaps we should consider adding a DCHECK in DumpWithoutCrashing if dump_without_crashing_function_ is nullptr, since this is normally not what we want...?
 
Labels: Pri-3
NextAction: 2019-07-09
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.

Sign in to add a comment