Cloud print can't launch service process |
||||||||||
Issue descriptionThe external cloud print binary, which is unmaintained and can apparently not be changed, relies on being able to launch chrome with --type=service and having it run the cloud print bridge service. Because of this, we need to revert the meaning of the "service" process type and use something else for services. I'm going to do: service -> service-runner cloud-print-service -> service to restore order to the universe. Marking RB-Stable and M59 to ensure this blocks further rollout of the broken M59.
,
Jun 21 2017
Well, even if the Cloud Print Service can be changed, I don't know the auto-update story.
,
Jun 21 2017
The cloud print service can be changed. I did recently touch it, but I don't know either what is the situation with auto-update and we should assume even if it does this is not a guarantee how many will not autoupdate. Provided that this is a rather simple fix in Chrome I would suggest we revert to the working situation (...or alias the old names to the new ones).
,
Jun 21 2017
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac96669f98f896188093803c3773113cb4b692a0 commit ac96669f98f896188093803c3773113cb4b692a0 Author: Ken Rockot <rockot@chromium.org> Date: Wed Jun 21 17:29:09 2017 Revert cloud print service process type name to "service" This is a partial manual revert of r459483, where the "service" process type was renamed to "cloud-print-service" so that "service" could later be co-opted for a generic service process environment. That broke cloud printing. The manual revert here simply changes the constant values of the respective switches so that the previous cloud-print service behavior is preserved and the new service process type doesn't collide with it. Any additional hard-coded values or comments referring to "cloud-print-service" have also been changed to "service" here. BUG= 735471 Change-Id: I1b63314a1047e53bb968c760432cacb6c19ea34d Reviewed-on: https://chromium-review.googlesource.com/543558 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#481233} [modify] https://crrev.com/ac96669f98f896188093803c3773113cb4b692a0/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/ac96669f98f896188093803c3773113cb4b692a0/chrome/common/chrome_switches.cc [modify] https://crrev.com/ac96669f98f896188093803c3773113cb4b692a0/chrome/common/extensions/manifest_handlers/app_launch_info.cc [modify] https://crrev.com/ac96669f98f896188093803c3773113cb4b692a0/chrome/install_static/install_util.cc [modify] https://crrev.com/ac96669f98f896188093803c3773113cb4b692a0/components/crash/content/app/breakpad_win.cc [modify] https://crrev.com/ac96669f98f896188093803c3773113cb4b692a0/services/service_manager/embedder/switches.cc
,
Jun 21 2017
It might take an hour or two, but I'm in the process of testing the fix.
,
Jun 21 2017
Verified that this fixes the service startup issue on ToT.
,
Jun 22 2017
,
Jun 22 2017
approving merge to m60.
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ad53e775dd83b08523fdd951f8a079be192a8a commit 16ad53e775dd83b08523fdd951f8a079be192a8a Author: Ken Rockot <rockot@chromium.org> Date: Thu Jun 22 05:03:38 2017 Revert cloud print service process type name to "service" This is a partial manual revert of r459483, where the "service" process type was renamed to "cloud-print-service" so that "service" could later be co-opted for a generic service process environment. That broke cloud printing. The manual revert here simply changes the constant values of the respective switches so that the previous cloud-print service behavior is preserved and the new service process type doesn't collide with it. Any additional hard-coded values or comments referring to "cloud-print-service" have also been changed to "service" here. BUG= 735471 TBR=rockot@chromium.org (cherry picked from commit ac96669f98f896188093803c3773113cb4b692a0) Change-Id: I1b63314a1047e53bb968c760432cacb6c19ea34d Reviewed-on: https://chromium-review.googlesource.com/543558 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#481233} Reviewed-on: https://chromium-review.googlesource.com/544777 Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#440} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/16ad53e775dd83b08523fdd951f8a079be192a8a/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/16ad53e775dd83b08523fdd951f8a079be192a8a/chrome/common/chrome_switches.cc [modify] https://crrev.com/16ad53e775dd83b08523fdd951f8a079be192a8a/chrome/common/extensions/manifest_handlers/app_launch_info.cc [modify] https://crrev.com/16ad53e775dd83b08523fdd951f8a079be192a8a/chrome/install_static/install_util.cc [modify] https://crrev.com/16ad53e775dd83b08523fdd951f8a079be192a8a/components/crash/content/app/breakpad_win.cc [modify] https://crrev.com/16ad53e775dd83b08523fdd951f8a079be192a8a/services/service_manager/embedder/switches.cc
,
Jun 22 2017
,
Jun 22 2017
M59 merge CL is ready to go, just awaiting approval. For reference: https://chromium-review.googlesource.com/c/544795/
,
Jun 22 2017
Confirmed with rockot@, this is well tested manually in M60 and M59 branches. Approving merge for M59. Branch: 3071
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26b276cd600017b8ef281f130d550211ca59876a commit 26b276cd600017b8ef281f130d550211ca59876a Author: Ken Rockot <rockot@chromium.org> Date: Thu Jun 22 18:13:31 2017 Revert cloud print service process type name to "service" This is a partial manual revert of r459483, where the "service" process type was renamed to "cloud-print-service" so that "service" could later be co-opted for a generic service process environment. That broke cloud printing. The manual revert here simply changes the constant values of the respective switches so that the previous cloud-print service behavior is preserved and the new service process type doesn't collide with it. Any additional hard-coded values or comments referring to "cloud-print-service" have also been changed to "service" here. BUG= 735471 TBR=rockot@chromium.org (cherry picked from commit ac96669f98f896188093803c3773113cb4b692a0) Change-Id: I1b63314a1047e53bb968c760432cacb6c19ea34d Reviewed-on: https://chromium-review.googlesource.com/543558 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#481233} Reviewed-on: https://chromium-review.googlesource.com/544795 Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/branch-heads/3071@{#818} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/26b276cd600017b8ef281f130d550211ca59876a/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/26b276cd600017b8ef281f130d550211ca59876a/chrome/common/chrome_switches.cc [modify] https://crrev.com/26b276cd600017b8ef281f130d550211ca59876a/chrome/common/extensions/manifest_handlers/app_launch_info.cc [modify] https://crrev.com/26b276cd600017b8ef281f130d550211ca59876a/components/crash/content/app/breakpad_win.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by roc...@chromium.org
, Jun 21 2017