New issue
Advanced search Search tips
Starred by 2 users
Status: Fixed
Owner:
Closed: Jun 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 563816



Sign in to add a comment
[OffscreenCanvas] OffscreenCanvasFrameDispatcherImpl::ReclaimResources is leaking resources
Project Member Reported by junov@chromium.org, Jun 21 Back to list
In the case where resources are not backed by an SkImage (e.g. the non-gpu-accelerated cases). ReclaimResourceInternal is not being called, causing a resource leak.
 
Project Member Comment 1 by bugdroid1@chromium.org, Jun 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07708943258531dcacbd85b3fc54459989ca5bbd

commit 07708943258531dcacbd85b3fc54459989ca5bbd
Author: Justin Novosad <junov@chromium.org>
Date: Wed Jun 21 18:44:30 2017

Fix leak in OffscreenCanvasFrameDispatcherImpl

This change ensures that ReclaimResources always calls
ReclaimResourceInternal to avoid leaking resources in cases
where the canvas is not backed by an SkImage. It also simplifies
ReclaimResources by always waiting on the sync token.  There was
no measurable advantage in deferring the wait.

Bug:  735470 
Change-Id: I810ec1d016d1f312d9b074aff7ab8c088b188705
Reviewed-on: https://chromium-review.googlesource.com/543436
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481258}
[modify] https://crrev.com/07708943258531dcacbd85b3fc54459989ca5bbd/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

Status: Fixed
Sign in to add a comment