New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735466 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Show direction (incoming vs outgoing) of websocket frames somewhere

Reported by jeromin....@gmail.com, Jun 21 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3135.5 Safari/537.36

Steps to reproduce the problem:
1. Have an website with many incoming and outgoing websocket frames
2. try to debug

What is the expected behavior?
I should get the direction without thinking about it.

What went wrong?
Only the background color of the WS frame table color codes the direction. 
* White is incoming (not intuitive)
* Light green is outgoing (not intuitive)
* blue is selected frame (what direction?) in a focused row
* light blue is selected frame (what direction?) in an unfocused row (too similar to light green)

Look at the screenshot and tell me 
* in chromeWebsocketFocus.png which direction the selected frame is.
* in chromeWebsocketUnfocus.png which direction the selected frame is and which frame is selected in the table

Did this work before? No 

Chrome version: 61.0.3135.5  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
chromeWebsocketFocus.PNG
56.2 KB View Download
chromeWebsocketUnfocus.PNG
55.9 KB View Download
Labels: Needs-Triage-M61

Comment 2 by ajha@chromium.org, Jun 22 2017

Cc: ajha@chromium.org
Components: -Platform>DevTools Platform>DevTools>Network
Labels: -Type-Bug -Needs-Triage-M61 M-61 OS-Linux OS-Mac Type-Feature
Owner: allada@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to allada@ for more inputs and for related work ( Issue 682335 ,  Issue 717962 ).Triaging this as Feature request.


Comment 3 by allada@chromium.org, Jul 18 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f4878140dd2c3072c57e4a1b75564385717c328

commit 9f4878140dd2c3072c57e4a1b75564385717c328
Author: Nathan Bruer <allada@chromium.org>
Date: Tue Jul 25 01:47:36 2017

[Devtools] Added upload/download icon to websocket frames

Adds icons to show weather frames are being uploaded or downloaded
for websockets in network panel.

see: http://imgur.com/a/B9b5p

BUG= 735466 
R=einbinder,caseq

Change-Id: I721a305a3fb35bbb2cd8a56faa83660b5f3a2186
Reviewed-on: https://chromium-review.googlesource.com/576395
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489183}
[modify] https://crrev.com/9f4878140dd2c3072c57e4a1b75564385717c328/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
[modify] https://crrev.com/9f4878140dd2c3072c57e4a1b75564385717c328/third_party/WebKit/Source/devtools/front_end/network/webSocketFrameView.css

Comment 5 by allada@chromium.org, Jul 25 2017

Status: Fixed (was: Started)

Comment 6 by kayce@google.com, Aug 28 2017

Labels: DevTools-Release-Notes-62

Sign in to add a comment