New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735424 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: 2
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

PlzNavigate: DumpResourceLoad |main_document_url| is empty.

Project Member Reported by arthurso...@chromium.org, Jun 21 2017

Issue description

Chrome Version: r480850
This happens only with PlzNavigate(--enable-browser-side-navigation)

A regression happens for the tests:
* fast/loader/main-document-url-for-non-http-loads.html
* http/tests/cache/iframe-304-crash.html
* http/tests/history/post-replace-state-reload.html
* http/tests/loading/307-after-303-after-post.html
* http/tests/loading/redirect-methods.html
* http/tests/misc/window-dot-stop.html
* http/tests/navigation/location-reload-after-post.php

It looks like the problem is that in:
```
WebFrameTestClient::WillSendRequest([...]) {
[...]
  if (test_runner()->shouldDumpResourceLoadCallbacks()) {
    delegate_->PrintMessage(DescriptionSuitableForTestResult(request_url));
    delegate_->PrintMessage(" - willSendRequest <NSURLRequest URL ");
    delegate_->PrintMessage(
        DescriptionSuitableForTestResult(request_url).c_str());
    delegate_->PrintMessage(", main document URL ");
    delegate_->PrintMessage(URLDescription(main_document_url).c_str());
    delegate_->PrintMessage(", http method ");
    delegate_->PrintMessage(request.HttpMethod().Utf8().data());
    delegate_->PrintMessage(">\n");
  }
[...]
}
```

|main_document_url| is empty.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f06bfc089846a2175801cf7d249f292cfb337940

commit f06bfc089846a2175801cf7d249f292cfb337940
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Tue Jun 27 14:34:02 2017

PlzNavigate: fix empty FirstPartyForCookies in tests.

This CL swaps the order of execution of WebFrameTestClient::WillSendRequest and
the part where FirstPartyForCookies and RequestorOrigin are set.

FirstPartyForCookies is used in WebFrameTestClient::WillSendRequest.
Using the wrong order caused the following test to fail:
TEST=
 * external/wpt/url/failure.html
 * fast/loader/main-document-url-for-non-http-loads.html
 * http/tests/cache/iframe-304-crash.html
 * http/tests/history/post-replace-state-reload.html
 * http/tests/inspector/network/network-datareceived.html
 * http/tests/inspector/resource-parameters-ipv6.html
 * http/tests/loading/307-after-303-after-post.html
 * http/tests/loading/redirect-methods.html
 * http/tests/misc/window-dot-stop.html
 * http/tests/navigation/location-reload-after-post.php

BUG= 735424 

Review-Url: https://codereview.chromium.org/2953583002
Cr-Commit-Position: refs/heads/master@{#482621}

[modify] https://crrev.com/f06bfc089846a2175801cf7d249f292cfb337940/content/renderer/render_frame_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment