New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735423 link

Starred by 1 user
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Jun 2017
Cc:
█ msrchandra@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference in content::BlinkTestController::OnAllServiceWorkersCleared

Project Member Reported by ClusterFuzz, Jun 21 2017 
Detailed report: https://clusterfuzz.com/testcase?key=4907159036100608

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference
Crash Address: 0x000000000000
Crash State:
  content::BlinkTestController::OnAllServiceWorkersCleared
  base::debug::TaskAnnotator::RunTask
  base::MessageLoop::RunTask
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=480658:480695

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4907159036100608


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

Comment 1 by msrchandra@chromium.org, Jun 21 2017

Cc: msrchandra@chromium.org
Labels: M-61 Test-Predator-Wrong
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.
Assigning to the concern owner from CL --
https://chromium.googlesource.com/chromium/src/+log/96f253a05da76269f1dfa369f60c0550ddd7d401..f1b5b08b61b3f3f23d2f6bd82339b20a7141603a?pretty=fuller

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/96c9582ab93d94dd07dfe3ff21133082a798728a

@lukasza -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by lukasza@chromium.org, Jun 21 2017

Cc: lukasza@chromium.org
 Issue 735325  has been merged into this issue.

Comment 3 by lukasza@chromium.org, Jun 21 2017

Cc: -lukasza@chromium.org
It does seem related to r480692 - I'll try to take a closer look later today or tomorrow.
Project Member

Comment 4 by ClusterFuzz, Jun 21 2017

Labels: OS-Mac

Comment 5 by lukasza@chromium.org, Jun 21 2017

Status: Started (was: Assigned)
WIP CL @ https://codereview.chromium.org/2946103003
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3bc33806c5940f54f91f4c57736e8b90a85b03

commit 8b3bc33806c5940f54f91f4c57736e8b90a85b03
Author: lukasza <lukasza@chromium.org>
Date: Thu Jun 22 17:03:46 2017

Protect against |main_window_| being null.

BlinkTestController::OnAllServiceWorkersCleared method needs to be
protected against a scenario where |main_window_| is null (e.g. this
field can be reset inside DiscardMainWindow if web contents are
destroyed during the test;  this wasn't an issue before r480692, because
back then we would just send an IPC to a routing id of a destroyed
RenderViewHost).

BUG= 735423 

Review-Url: https://codereview.chromium.org/2946103003
Cr-Commit-Position: refs/heads/master@{#481570}

[modify] https://crrev.com/8b3bc33806c5940f54f91f4c57736e8b90a85b03/content/shell/browser/layout_test/blink_test_controller.cc

Comment 7 by lukasza@chromium.org, Jun 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment