New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735418 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Blocking:
issue 570091



Sign in to add a comment

Compile fails on waterfall

Project Member Reported by serg...@chromium.org, Jun 21 2017

Issue description

../../breakpad/src/common/memory.h:50:10: fatal error: 'third_party/lss/linux_syscall_support.h' file not found
#include "third_party/lss/linux_syscall_support.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I've also noticed that after running gclient-sync on local checkout I got the following message:

WARNING: 'src/third_party/lss' is no longer part of this client.  It is recommended that you manually remove it.

 
Owner: phajdan.jr@chromium.org
Revert is done here: https://chromium.googlesource.com/chromium/tools/build/+/195e0b5b0f46a6be8793bbc279e1fa014e901b8a 

next runs of build should pick this up. Assigning to Pawel to handle the rest.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/806b70187d8bff7c51fb3bad730b189b505ed937

commit 806b70187d8bff7c51fb3bad730b189b505ed937
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jun 21 11:48:17 2017

Revert "gclient: include deps_os entries in dependencies"

This reverts commit 529d6a4e4aed18b48a8fc0e9351a5d4a07ca597d.

Reason for revert: broke developers and CI/Try checkouts.

Bug:  735418 

Original change's description:
> gclient: include deps_os entries in dependencies
> 
> Keep deps_os entries in dependencies, just with should_process set to False
> for entries not applicable to target OS list.
> 
> This way gclient flatten has proper access to dependencies e.g. to evaluate
> recursedeps referring to deps_os entries other than active OS.
> 
> Allow but ignore deps_os overriding a value with None, since that does not
> fit the new model. There's no correctness harm in not checking out a repo.
> 
> Allow "overrides" setting given dependency to the same value. This seems
> fairly common, especially for mac/ios and unix/android, even in chromium/src.
> 
> Bug:  570091 
> Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72
> Reviewed-on: https://chromium-review.googlesource.com/541280
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

TBR=phajdan.jr@chromium.org,dpranke@chromium.org

Change-Id: Iaa0c39865908a5b25c15dda54ba61c0e76abcbea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  570091 
Reviewed-on: https://chromium-review.googlesource.com/543138
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/806b70187d8bff7c51fb3bad730b189b505ed937/testing_support/fake_repos.py
[modify] https://crrev.com/806b70187d8bff7c51fb3bad730b189b505ed937/tests/gclient_test.py
[modify] https://crrev.com/806b70187d8bff7c51fb3bad730b189b505ed937/gclient.py
[modify] https://crrev.com/806b70187d8bff7c51fb3bad730b189b505ed937/tests/gclient_smoketest.py

Labels: -Pri-0 Pri-1 Type-Bug-Regression
Note the win compile failure looked a bit different:
https://build.chromium.org/p/chromium/builders/Win/builds/56328
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/fd0057e42be2906e79060085201494e7df1d0e8b

commit fd0057e42be2906e79060085201494e7df1d0e8b
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Jun 21 12:25:15 2017

gclient: include deps_os entries in dependencies (reland #1)

This is a reland of https://chromium-review.googlesource.com/c/541280/
with a fix for https://bugs.chromium.org/p/chromium/issues/detail?id=735418
(patchset 1 is original patch, patchset 2 has the fix).

Keep deps_os entries in dependencies, just with should_process set to False
for entries not applicable to target OS list.

This way gclient flatten has proper access to dependencies e.g. to evaluate
recursedeps referring to deps_os entries other than active OS.

Allow but ignore deps_os overriding a value with None, since that does not
fit the new model. There's no correctness harm in not checking out a repo.

Allow "overrides" setting given dependency to the same value. This seems
fairly common, especially for mac/ios and unix/android, even in chromium/src.

Bug:  570091 ,  735418 
Change-Id: I6eba0e4be202212eb86cb959c18f2b2f0c1452b9
Reviewed-on: https://chromium-review.googlesource.com/543076
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/fd0057e42be2906e79060085201494e7df1d0e8b/testing_support/fake_repos.py
[modify] https://crrev.com/fd0057e42be2906e79060085201494e7df1d0e8b/tests/gclient_test.py
[modify] https://crrev.com/fd0057e42be2906e79060085201494e7df1d0e8b/gclient.py
[modify] https://crrev.com/fd0057e42be2906e79060085201494e7df1d0e8b/tests/gclient_smoketest.py

Blocking: 570091
Status: Fixed (was: Assigned)
Cc: -vabr@chromium.org

Sign in to add a comment