New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735416 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue v8:6508



Sign in to add a comment

Add alerts for some bigger wasm perf benchmarks

Project Member Reported by clemensh@chromium.org, Jun 21 2017

Issue description

Hi Annie,

could you please add alerts for the following graphs:
internal.client.v8/*/v8/Wasm/AngryBots/*
internal.client.v8/*/v8/Unity/*/*
internal.client.v8/*/v8/Unity-asm-wasm/*/*

Example graphs here:
https://chromeperf.appspot.com/report?sid=400cffc9a4f825ddf7b65d94d0083e3ac7e32e473a1e6a545288e9636045091f&start_rev=45158&end_rev=46035

All alerts should be redirected to wasm-perf@google.com and shown on the "V8 Wasm Perf Sheriff" dashboard:
https://chromeperf.appspot.com/alerts?sortby=end_revision&sortdirection=down&sheriff=V8%20Wasm%20Perf%20Sheriff

Thanks, and let me know if you are missing any information.
 
Status: Fixed (was: Assigned)
Monitoring added.
Thanks! May I ask a follow-up question: We sometimes use the unit "microseconds", for which chromeperf does not know whether upper or lower is better.
Is there a list of existing units somewhere?
If there is nothing for microseconds: Can this list be extended?
Cc: eakuefner@chromium.org simonhatch@chromium.org
+eakuefner, simonhatch FYI

Here's the documentation on the dashboard data format, you should be able to set improvement_direction or higher_is_better depending on which format you use: https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md
+machenbach

Michael, where does this connect to our v8-perf tests? The output of run_perf.py does not seem to fit the dashboard data format.
Cc: machenb...@chromium.org
Damn, forgot to +machenbach.
Thanks Michael and Annie, that last issue was fixed yesterday by replacing the unit 'microseconds' by 'us'.

Sign in to add a comment