For testing we are using separate DB for breaking news pushed via GCM. However, we should reduce the number of DB used in order to reduce the memory footprint before proper launch.
Note: feel free to adjust milestone label
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44915afe9ed818d3580414a02baf9befb30cbe3d commit 44915afe9ed818d3580414a02baf9befb30cbe3d Author: Vitalii Iarko <vitaliii@chromium.org> Date: Wed Aug 02 15:09:44 2017 [NTP::Push] Add RemoteSuggestionsProvider callback for pushing. This CL adds a function to push an article suggestion to the top of Articles section in RemoteSuggestionsProvider. Also a button added to snippets_internals to push a dummy suggestion. Bug: 742225, 735402 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic41f831884d9487a7e567db21b83371ae1834655 Reviewed-on: https://chromium-review.googlesource.com/585127 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491374} [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/chrome/browser/resources/snippets_internals.html [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/chrome/browser/resources/snippets_internals.js [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/chrome/browser/ui/webui/snippets_internals_message_handler.h [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/components/ntp_snippets/remote/remote_suggestions_provider_impl.h [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc [modify] https://crrev.com/44915afe9ed818d3580414a02baf9befb30cbe3d/components/ntp_snippets/remote/test_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/049b018b14757fb507f7b8494062178027086893 commit 049b018b14757fb507f7b8494062178027086893 Author: Vitalii Iarko <vitaliii@chromium.org> Date: Mon Aug 07 15:58:57 2017 [NTP::Push] Connect handler to RemoteSuggestionsProviderImpl. This CL 1) deletes BreakingNewsSuggestionsProvider (including the category and constants); 2) wires up BreakingNewsGCMAppHandler and RemoteSuggestionsProviderImpl. Provider owns the handler, the handler notifies provider with pushed suggestions. Bug: 742225, 735402 Change-Id: I7fb24a22564498d270f533f5f68f3836a0dbe966 Reviewed-on: https://chromium-review.googlesource.com/601790 Reviewed-by: Alexei Svitkine (OOO July28-Aug6) <asvitkine@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#492331} [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/BUILD.gn [delete] https://crrev.com/81d004bf3b3efb3c0c4a7bb4a62520504cfd8f0f/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider_unittest.cc [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/category.h [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/content_suggestions_metrics.cc [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/ntp_snippets_constants.cc [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/ntp_snippets_constants.h [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/remote/remote_suggestions_provider_impl.h [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc [modify] https://crrev.com/049b018b14757fb507f7b8494062178027086893/tools/metrics/histograms/histograms.xml
There is one provider and, thus, one database now.
Comment 1 by fi...@chromium.org
, Jul 21 2017Status: Assigned (was: Untriaged)