New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735395 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

DCHECK(success) failure in browser/top_sites_impl.cc 776

Project Member Reported by primiano@chromium.org, Jun 21 2017

Issue description

OS: OSX
Version: ToT @ 06861239bfdf6351fa5279a69080f5f14b07cfb1

Just hit this DCHECK while trying to use chrome with dcheck_always_on

[77999:775:0621/111926.103629:FATAL:top_sites_impl.cc(776)] Check failed: success.
0   libbase.dylib                       0x0000000103d3873c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   libbase.dylib                       0x0000000103d62852 logging::LogMessage::~LogMessage() + 210
2   libchrome_dll.dylib                 0x00000001059fa71a history::TopSitesImpl::SetTopSites(std::__1::vector<history::MostVisitedURL, std::__1::allocator<history::MostVisitedURL> > const&, history::TopSitesImpl::CallLocation) + 954
3   libchrome_dll.dylib                 0x00000001059fb15b history::TopSitesImpl::OnTopSitesAvailableFromHistory(std::__1::vector<history::MostVisitedURL, std::__1::allocator<history::MostVisitedURL> > const*) + 107
4   libchrome_dll.dylib                 0x00000001059eaf35 base::internal::Invoker<base::internal::BindState<base::Callback<void (std::__1::vector<history::MostVisitedURL, std::__1::allocator<history::MostVisitedURL> > const*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>, base::internal::OwnedWrapper<std::__1::vector<history::MostVisitedURL, std::__1::allocator<history::MostVisitedURL> > > >, void ()>::Run(base::internal::BindStateBase*) + 117
5   libbase.dylib                       0x0000000103ddaa5d base::(anonymous namespace)::RunIfNotCanceledThenUntrack(base::CancellationFlag const*, base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>, base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>) + 61
6   libbase.dylib                       0x0000000103ddb806 base::internal::Invoker<base::internal::BindState<void (*)(base::CancellationFlag const*, base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>, base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>), base::internal::OwnedWrapper<base::CancellationFlag>, base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>, base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0> >, void ()>::RunOnce(base::internal::BindStateBase*) + 70
7   libbase.dylib                       0x0000000103df4571 base::(anonymous namespace)::PostTaskAndReplyRelay::RunReplyAndSelfDestruct() + 193
8   libbase.dylib                       0x0000000103d390a6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 310
9   libbase.dylib                       0x0000000103d7cde9 base::MessageLoop::RunTask(base::PendingTask*) + 441
10  libbase.dylib                       0x0000000103d7d255 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 213
11  libbase.dylib                       0x0000000103d7d5b9 base::MessageLoop::DoWork() + 425
12  libbase.dylib                       0x0000000103d8165a base::MessagePumpCFRunLoopBase::RunWork() + 42
13  libbase.dylib                       0x0000000103d64a1a base::mac::CallWithEHFrame(void () block_pointer) + 10
14  libbase.dylib                       0x0000000103d80f7f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63


Marc, you seem the last one who touched that DCHECK in https://chromium-review.googlesource.com/531085.
 

Comment 1 by treib@chromium.org, Jun 21 2017

Status: Assigned (was: Unconfirmed)
Indeed, I added that DCHECK recently - apparently that wasn't correct. The immediate fix is to remove it again; I'll send out a CL shortly.

Comment 2 by treib@chromium.org, Jun 21 2017

Status: Started (was: Assigned)
(BTW: Thanks for reporting, and sorry for the trouble - I know how annoying wrong DCHECKs can be!)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192b95f532c4917c045490425c3e6a093bf97987

commit 192b95f532c4917c045490425c3e6a093bf97987
Author: Marc Treib <treib@chromium.org>
Date: Thu Jun 22 08:04:57 2017

Remove wrong DCHECK in TopSitesImpl

The DCHECK was added recently in
https://chromium-review.googlesource.com/c/531085/, but turned out to
be wrong (see bug). This CL replaces the DCHECK with a TODO to
investigate.

Bug:  735395 
Change-Id: Ib1b6b7eee0d88ec471d9e7966ecc05c779ce58fd
Reviewed-on: https://chromium-review.googlesource.com/543036
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481478}
[modify] https://crrev.com/192b95f532c4917c045490425c3e6a093bf97987/components/history/core/browser/top_sites_impl.cc

Comment 4 by treib@chromium.org, Jun 22 2017

Labels: -Pri-1 OS-Chrome OS-Linux OS-Windows Pri-3
This fixes the DCHECK failure. I'm leaving the bug open as P3 for the investigation on why it happened.

Comment 5 by fi...@chromium.org, Jul 21 2017

Labels: zine-triaged

Comment 6 by treib@chromium.org, Nov 15 2017

Labels: -Type-Bug Type-Task

Comment 7 by fi...@chromium.org, Jan 12 2018

Components: -UI>Browser>NewTabPage UI>Browser>ContentSuggestions

Comment 8 by treib@chromium.org, Jan 12 2018

Components: -UI>Browser>ContentSuggestions UI>Browser>NewTabPage
Nope, this one is not ContentSuggestions :)
Status: WontFix (was: Started)

Sign in to add a comment