New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735376 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
█ gajendr...@samsung.com
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
mac-bugs-priority@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Settings] Unnecessary text get selected and wrong context menu gets opened after right click action on link.

Reported by db...@etouch.net, Jun 21 2017 
Chrome Version: 61.0.3137.0 Revision 59326d74274f028a233a2561f940a84675e0c967-refs/heads/master@{#481056}
OS: Mac(10.11.6, 10.12.3)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings/resetProfileSettings?origin=userclick
(2) Right click on 'current settings' link and observe.

Actual: Unnecessary text get selected and wrong context menu gets opened after right click action on link.

Expected: Text should not selected after right clicking on link.

This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info.
Good build : 61.0.3132.0 
Bad build : 61.0.3134.0 

Note: Issue is not seen on Windows and Linux OS.
Actual_contextmenu.mov
3.0 MB Download
Expected_contextmenu.mov
1.1 MB Download

Comment 1 by rbasuvula@chromium.org, Jun 21 2017

Cc: rbasuvula@chromium.org gajendr...@samsung.com
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3132.0 (Revision:479900).
Bad build:61.0.3134.0 (Revision:480301).

You are probably looking for a change made after 479981 (known good), but no later than 479982 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/f5f880c3d9d32f6925c211cd4836701cd2a3cbb2..0721d307c2e650409d287b02ddeeed4d1635b086

From the CL above, assigning the issue to the concern owner

@gajendra.n: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2904783003
Note :Mac specific issue and Able to reproduce in latest Canary #61.0.3137.0.

Comment 2 by rbasuvula@chromium.org, Jun 21 2017

Labels: ReleaseBlock-Stable
Adding Release Block-Stable for this issue.Please remove if not the case.

Comment 3 by gajendr...@samsung.com, Jun 22 2017 

Seems the issue(regression) is only on MAC. On Linux, it is not reproducible.

Tested Chrome Version : Version 61.0.3137.0 (Developer Build) (64-bit)

The original issue ( https://bugs.chromium.org/p/chromium/issues/detail?id=691783 ) was specific to Linux, so I verified my changes only on Linux before the submitting the CL.

I do not have MAC setup in my workstation, so I will not be able to reproduce/fix it. Sorry for that :(.

If someone with MAC setup can fix the regression, it would be great. Otherwise, I can revert my commit. Please let me know your opinion.

Comment 4 by dschuyler@chromium.org, Jun 27 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b95ec337bd8db2a552574ca22fae4b163cb0443

commit 8b95ec337bd8db2a552574ca22fae4b163cb0443
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Jun 27 23:31:59 2017

[MD settings] prohibit selection of action-link label

This CL prevents accidental selection of action-link labels when trying
to click the button (which causes confusion).

Bug:  735376 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibccee0ede9b4e38951dce3fa678cba0867ae83c4
Reviewed-on: https://chromium-review.googlesource.com/550578
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482790}
[modify] https://crrev.com/8b95ec337bd8db2a552574ca22fae4b163cb0443/chrome/browser/resources/settings/settings_shared_css.html

Comment 7 by dschuyler@chromium.org, Jun 28 2017

Status: Fixed (was: Started)

Comment 8 by db...@etouch.net, Jul 11 2017

Labels: TE-Verified-M61 TE-Verified-M61.0.3053.4
Just to update:

Issue is fixed on latest dev build 61.0.3153.4
►

Sign in to add a comment