New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735364 link

Starred by 1 user
Status: Duplicate
Merged: issue 735550
Owner:
isherman@chromium.org
Closed: Jun 2017
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

enums.xml contains "type" attributes even though PRESUBMIT expects no type attributes exist

Project Member Reported by shimazu@chromium.org, Jun 21 2017 
I'm now trying to land a patch including a change in enums.xml but failed due to the following error on the presubmit bot.

This is the result of the tryserver:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fchromium_presubmit%2F469537%2F%2B%2Frecipes%2Fsteps%2Fpresubmit%2F0%2Fstdout

I guess several type="int" enums were mixed in after you landed the patch.

Comment 1 by shimazu@chromium.org, Jun 21 2017 

Sorry, I forgot to put a link to the CL. 
https://crrev.com/2941623002

Comment 2 by isherman@chromium.org, Jun 21 2017

Status: Started (was: Assigned)
https://codereview.chromium.org/2945333002/

Comment 3 by isherman@chromium.org, Jun 21 2017 

Looks like the error was introduced in https://codereview.chromium.org/2711543002

Comment 4 by isherman@chromium.org, Jun 22 2017

Status: Fixed (was: Started)
... which was reverted in https://codereview.chromium.org/2948943003

Comment 5 by isherman@chromium.org, Jun 22 2017

Mergedinto: 735550
Status: Duplicate (was: Fixed)
►

Sign in to add a comment