'Get help' link USB permission opens in other person instead of new tab
Reported by
sans...@etouch.net,
Jun 21 2017
|
|||||||
Issue descriptionChrome Version:60.0.3112.40(Official Build) 6de35395b27b983b671c777caa9a273017e80d62-refs/branch-heads/3112@{#412}-32/64 bit OS : Windows(7,8,10),Linux(14.04 LTS), Mac(10.11.6, 10.12.3) Precondition: Enable #enable-experimental-web-platform-features from chrome://flags. Steps: 1. Launch Chrome and add a person from switch person overlay. 2. Navigate to https://permission.site/ on newly added person and Click on 'USB' 3. Click on 'Get help' link of USB permission overlay and observe Actual: 'Get help' link opens in other person instead of new tab Expected: 'Get help' link should open in new tab Note: Incase of Linux and Mac, 'Get help' link automatically creates a new person (3). This is non-regression issue seen from M-55, since USB permission overlay was introduced in 55.0.2841.0
,
Jun 23 2017
,
Jun 26 2017
Assigning to Reilly to triage
,
Jun 26 2017
The code to open this dialog is UsbChooserController::OpenHelpCenterUrl: https://cs.chromium.org/chromium/src/chrome/browser/usb/usb_chooser_controller.cc?sq=package:chromium&l=176 This logic is also copied in BlueoothChooserController and comes down to: chrome::ScopedTabbedBrowserDisplayer browser_displayer( ProfileManager::GetActiveUserProfile()); DCHECK(browser_displayer.browser()); browser_displayer.browser()->OpenURL(content::OpenURLParams( GURL(chrome::kChooserUsbOverviewURL), content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false /* is_renderer_initialized */)); That this is creating a new profile implies that ProfileManager::GetActiveUserProfile() is not returning the profile of the user associated with the Browser in which the chooser is being displayed.
,
Jun 26 2017
This has been a problem since I can remember... See issue 646327 . In the end clearing the profile fixed the problem so we always closed the issues. I'm not entirely sure here but I think it Issue 684257 might be related.
,
Jun 26 2017
This issue may be also related to issue 735353 and issue 735531.
,
Jun 27 2017
Lowering priority: Low number of users (combination of 2 rare features: multi profile & USB/Bluetooth). Low severity. No work around needed for users.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed23c1c3b4a0bd7346088e790917daf31bbe2180 commit ed23c1c3b4a0bd7346088e790917daf31bbe2180 Author: Jun Cai <juncai@chromium.org> Date: Thu Jun 29 17:04:56 2017 Fix opening WebUSB chooser when user profile changes The "Get help" link uses ProfileManager::GetActiveUserProfile() to open a new tab for help page, and it causes the issue when the active user profile is removed or another user profile is created. This CL fixes it by using ProfileManager::GetLastUsedProfileAllowedByPolicy(). Bug: 735353 , 735360 Change-Id: I2b1989152cac8e698c7258920a2a401159eb6c50 Reviewed-on: https://chromium-review.googlesource.com/553725 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#483399} [modify] https://crrev.com/ed23c1c3b4a0bd7346088e790917daf31bbe2180/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc [modify] https://crrev.com/ed23c1c3b4a0bd7346088e790917daf31bbe2180/chrome/browser/usb/usb_chooser_controller.cc
,
Mar 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ranjitkan@chromium.org
, Jun 21 2017