Issue metadata
Sign in to add a comment
|
Regression: Unable to alter page zoom once pdf zoom is altered. |
||||||||||||||||||||||
Issue descriptionChrome Version:60.0.3112.40 OS:Ubuntu 14.04, Windows What steps will reproduce the problem? (1)Launch chrome and go to https://msu.edu/~urban/sme865/resources/embedded_pdf.html >> Click on page and zoom out page using ctrl+mouse wheel down (2)Now click inside page and zoom in page using ctrl+mouse wheel up (3)Now before zoom bubble vanishes click on reset and observe Expected: Should not be able to zoom in/out pdf separately and should be able to reset zoom level of page to default. Actual: Instead able to zoom in/out pdf separately and on clicking reset before zoom bubble gets vanished only pdf page zoom resets to default,By clicking outside the page zoom bubble vanishes and unable to reset rest of the page zoom. [Please refer video] This is a regression issue broken in M60. Will provide bisect info soon.
,
Jun 21 2017
Manual Bisect Info: ==================== Good Build:60.0.3109.0 Bad Build:60.0.3110.0
,
Jun 21 2017
Bisect Information: -------------------- Using per revision bisect providing information below. You are probably looking for a change made after 474175 (known good), but no later than 474176 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/9dd6cc8ed582ed45422be5c4a0dad00464d2639a..171284077b44d0102ffc9065331fb3b1efe3fb67 From the above CL suspecting the below change Review-Url: https://codereview.chromium.org/2888203006 slangley@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Since this is a recent regression observed on chrome latest M60 adding RB-Stable, please feel free to edit if this is not the case. Thanks!
,
Jun 27 2017
Just to update, Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version # 61.0.3141.0 slangley@ Could you please look into this issue. Thanks!
,
Jul 3 2017
Just to update, Still able to reproduce the issue on Win-10 using latest chrome version # 61.0.3147.0. slangley@ - Gentle Ping...!! Could you please have a look into this issue as it has been marked as a stable blocker. Thanks...!!
,
Jul 5 2017
Sorry I'm in hospital and can't look at it? Perhaps you can ask dcheng@? As mentioned in the code review, there should be no logic changes.
,
Jul 6 2017
,
Jul 6 2017
I'll try to take a look this week. thestig@, are there instructions on how to get a working pdf viewer in a custom chromium build?
,
Jul 6 2017
,
Jul 6 2017
The PDF Viewer has been fully open source for some time.
,
Jul 11 2017
Just to update the latest behavior. Still able to reproduce the issue on Win-10 using latest chrome version #61.0.3153.3. dcheng@ - Gentle Ping...!! Could you please have a look into the issue as it has been marked as a stable blocker. Thanks...!!
,
Jul 18 2017
Just to update, Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version # 61.0.3160.0 dcheng@ Could you please look into this issue as it has been marked as a stable blocker. Thanks!
,
Jul 18 2017
Sorry I missed that this was a stable blocker when I volunteered for this bug originally. I think I have a fix.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/212f8f9b75225b4a3b24975aac38d3987a3efba3 commit 212f8f9b75225b4a3b24975aac38d3987a3efba3 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Jul 20 02:47:45 2017 Fix WebViewImpl::SetZoomLevel to not be a no-op if a plugin is focused. Bug: 735358 Change-Id: Ibe2a98bd93c1e6288e7c8e9a3633f21e3433350a Reviewed-on: https://chromium-review.googlesource.com/577390 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#488110} [modify] https://crrev.com/212f8f9b75225b4a3b24975aac38d3987a3efba3/third_party/WebKit/Source/core/exported/WebViewTest.cpp [modify] https://crrev.com/212f8f9b75225b4a3b24975aac38d3987a3efba3/third_party/WebKit/Source/web/WebViewImpl.cpp
,
Jul 20 2017
,
Jul 20 2017
,
Jul 20 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20 2017
This needs to bake in canary for 24 hours, and then we can approve for merge.
,
Jul 24 2017
This change meets the bard and is approved for merge into M60
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/579d425199727402fbcf4041ce62488a35939eda commit 579d425199727402fbcf4041ce62488a35939eda Author: Daniel Cheng <dcheng@chromium.org> Date: Wed Jul 26 21:41:24 2017 Fix WebViewImpl::SetZoomLevel to not be a no-op if a plugin is focused. TBR=haraken@chromium.org,slangley@chromium.org (cherry picked from commit 212f8f9b75225b4a3b24975aac38d3987a3efba3) Bug: 735358 Change-Id: Ibe2a98bd93c1e6288e7c8e9a3633f21e3433350a Reviewed-on: https://chromium-review.googlesource.com/577390 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488110} Reviewed-on: https://chromium-review.googlesource.com/587407 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#676} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/579d425199727402fbcf4041ce62488a35939eda/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/579d425199727402fbcf4041ce62488a35939eda/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90725c2fef7ba4d0e8b8a2689a3fbc81774b5b23 commit 90725c2fef7ba4d0e8b8a2689a3fbc81774b5b23 Author: Alexandre Elias <aelias@chromium.org> Date: Thu Jul 27 21:22:05 2017 Revert "Fix WebViewImpl::SetZoomLevel to not be a no-op if a plugin is focused." This reverts commit 579d425199727402fbcf4041ce62488a35939eda. Reason for revert: Breaks compile due to missing include on branch BUG=749406 Original change's description: > Fix WebViewImpl::SetZoomLevel to not be a no-op if a plugin is focused. > > TBR=haraken@chromium.org,slangley@chromium.org > > (cherry picked from commit 212f8f9b75225b4a3b24975aac38d3987a3efba3) > > Bug: 735358 > Change-Id: Ibe2a98bd93c1e6288e7c8e9a3633f21e3433350a > Reviewed-on: https://chromium-review.googlesource.com/577390 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Stuart Langley <slangley@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#488110} > Reviewed-on: https://chromium-review.googlesource.com/587407 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/branch-heads/3112@{#676} > Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} TBR=dcheng@chromium.org,haraken@chromium.org,slangley@chromium.org Change-Id: I771d9c74373494de6f970cf304ac02992292f005 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 735358 Reviewed-on: https://chromium-review.googlesource.com/590648 Reviewed-by: Alexandre Elias <aelias@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#684} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/90725c2fef7ba4d0e8b8a2689a3fbc81774b5b23/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/90725c2fef7ba4d0e8b8a2689a3fbc81774b5b23/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07d7dbdc27f3f4d66557946d75821107575a04f6 commit 07d7dbdc27f3f4d66557946d75821107575a04f6 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Jul 27 22:16:31 2017 Reland: Fix WebViewImpl::SetZoomLevel to not be a no-op if a plugin is focused. (cherry picked from commit 212f8f9b75225b4a3b24975aac38d3987a3efba3) Bug: 735358 Change-Id: I4157b38acb3a305ad882bf7d2dc542351face30e Reviewed-on: https://chromium-review.googlesource.com/577390 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488110} Reviewed-on: https://chromium-review.googlesource.com/590193 Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#686} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/07d7dbdc27f3f4d66557946d75821107575a04f6/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/07d7dbdc27f3f4d66557946d75821107575a04f6/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Aug 2 2017
Checked the issue on latest stable 60.0.3112.90 on Ubuntu 14.04 with steps mentioned in comment#0 and is no longer reproducible. Hence adding Verified labels. Thnaks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Jun 21 2017