Reading from WebManifest icons should prefer 192x192 |
|||||
Issue descriptionThe current implementation, as a side effect of https://codereview.chromium.org/2891333002, prioritizes icons of size 144x144 (kTouchIconSize) instead of 192x192 (kNonTouchLargestIconSize).
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/059780c6a5531bba2ac89b4ba3278ed6678aa892 commit 059780c6a5531bba2ac89b4ba3278ed6678aa892 Author: mastiz <mastiz@chromium.org> Date: Fri Jun 23 11:51:39 2017 Prefer 192x192 icons from Web Manifests instead of 144x144 Fixes an undesirable side effect of https://codereview.chromium.org/2891333002 by overriding the desired size for manifest icons regardless of handler_type_. BUG= 735354 Review-Url: https://codereview.chromium.org/2948963002 Cr-Commit-Position: refs/heads/master@{#481854} [modify] https://crrev.com/059780c6a5531bba2ac89b4ba3278ed6678aa892/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/059780c6a5531bba2ac89b4ba3278ed6678aa892/components/favicon/core/favicon_handler.h [modify] https://crrev.com/059780c6a5531bba2ac89b4ba3278ed6678aa892/components/favicon/core/favicon_handler_unittest.cc
,
Jun 23 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01e7b505db0db95de24cb648c244fdad10a3929d commit 01e7b505db0db95de24cb648c244fdad10a3929d Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Jul 28 02:34:54 2017 Fix applied maximum size for icons from Web Manifests The desired size should be 192x192 instead of 144x144. A previous patch (https://codereview.chromium.org/2948963002) did fix the image selection but the maximum cap of 144x144 was still applied during image download, leading to undesired downsampling. Some refactoring is required in tests to exercise this logic, such that FakeImageDownloader now mimics the real downloader's ability to resample images. Tests also now adopt the appropriate handler and icon types. Bug: 735354 Change-Id: Ia73e27a684137af715f72c4c98129354dfbf2e2a Reviewed-on: https://chromium-review.googlesource.com/590228 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#490216} [modify] https://crrev.com/01e7b505db0db95de24cb648c244fdad10a3929d/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/01e7b505db0db95de24cb648c244fdad10a3929d/components/favicon/core/favicon_handler.h [modify] https://crrev.com/01e7b505db0db95de24cb648c244fdad10a3929d/components/favicon/core/favicon_handler_unittest.cc
,
Aug 1 2017
,
Aug 2 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/244d980cb5b58ade1e62b83d7b0b986af7d9f3f8 commit 244d980cb5b58ade1e62b83d7b0b986af7d9f3f8 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Aug 02 13:17:48 2017 Fix applied maximum size for icons from Web Manifests The desired size should be 192x192 instead of 144x144. A previous patch (https://codereview.chromium.org/2948963002) did fix the image selection but the maximum cap of 144x144 was still applied during image download, leading to undesired downsampling. Some refactoring is required in tests to exercise this logic, such that FakeImageDownloader now mimics the real downloader's ability to resample images. Tests also now adopt the appropriate handler and icon types. TBR=mastiz@chromium.org (cherry picked from commit 01e7b505db0db95de24cb648c244fdad10a3929d) Bug: 735354 Change-Id: Ia73e27a684137af715f72c4c98129354dfbf2e2a Reviewed-on: https://chromium-review.googlesource.com/590228 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490216} Reviewed-on: https://chromium-review.googlesource.com/597854 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#236} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/244d980cb5b58ade1e62b83d7b0b986af7d9f3f8/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/244d980cb5b58ade1e62b83d7b0b986af7d9f3f8/components/favicon/core/favicon_handler.h [modify] https://crrev.com/244d980cb5b58ade1e62b83d7b0b986af7d9f3f8/components/favicon/core/favicon_handler_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mastiz@chromium.org
, Jun 21 2017