Gerrit git-cl is going to be stripping R= lines from the commit description, so that reviewers exist only in metadata. I guess it can strip R: lines too :)

Here's a very rough and obviously incomplete start: https://chromium-review.googlesource.com/c/543568/

I uploaded it so that I can come back to it later, but I'm not going to be able to dedicate more time to untangling the mess that is git-cl-upload and update_reviewers() until after launch.

Does that mean I can start using R: at some point?

Once that CL lands, yes, but I'm not dedicating time to that CL at the moment.

In the mean time, the easiest workaround is to use "git cl upload -r whoever" instead of typing the R: line in the commit message. The flag will do the right thing.

Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

It's not necessary, since reviewers are tracked in change metadata and get added in Reviewed-By footers at submission time.

 Issue 800824  has been merged into this issue.

I'm copying one of the issues I raised in  bug 800824  since it was duplicated against this one.

I noticed that TBR: foo does NOT seem to work while TBR=foo does. That seems inconsistent - we should either switch to just one valid syntax, or allow both forms for everything. Specifically, if you set TBR: foo, Gerrit doesn't prompt you to CR+1, whereas if you set TBR=foo, it does. Haven't checked whether the CQ accepts both syntaxes either. Consider this a request to please audit every part of the code that checks for these, and maybe update canonical documentation of all of them.

See https://groups.google.com/a/chromium.org/d/msg/infra-dev/OKilo5BxUyo/OIkiT4wZDgAJ; I'm removing TBR entirely in the very near future. Resolving this bug is part of that effort.