New issue
Advanced search Search tips

Issue 735347 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug


Participants' hotlists:
Downloads-Framework-Service


Sign in to add a comment

[Download Service] Notify Clients of initialization failure

Project Member Reported by dtrainor@chromium.org, Jun 21 2017

Issue description

Add OnServiceUnavailable() to the Client API.  If the service fails the Clients need to be known so they can figure out what to do instead of waiting forever or polling for the service.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df66003302472598012e7b88da3b974a5025c31f

commit df66003302472598012e7b88da3b974a5025c31f
Author: David Trainor <dtrainor@chromium.org>
Date: Thu Jul 13 00:20:46 2017

Expose DownloadService failure to Clients

Add the capability for clients to be notified when the service fails
initialization.

Bug:  735347 
Change-Id: Id274a68c76893ae2286f1f9945a1255d8b592aaa
Reviewed-on: https://chromium-review.googlesource.com/542476
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486179}
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/chrome/browser/offline_pages/prefetch/offline_prefetch_download_client.cc
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/chrome/browser/offline_pages/prefetch/offline_prefetch_download_client.h
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/components/download/internal/controller_impl.cc
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/components/download/internal/controller_impl.h
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/components/download/internal/controller_impl_unittest.cc
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/components/download/internal/test/empty_client.cc
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/components/download/internal/test/empty_client.h
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/components/download/internal/test/mock_client.h
[modify] https://crrev.com/df66003302472598012e7b88da3b974a5025c31f/components/download/public/client.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29cb248850060bd37f4105bcd61be7c18c04d599

commit 29cb248850060bd37f4105bcd61be7c18c04d599
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Nov 07 13:32:12 2017

Rewriting wait-for-video functions to use promises.

The end goal here is to get rid of addExpectedEvent() / eventOccurred()
and replace with promises, which is more standard. I hope we will end
up getting rid of all the callback complexity and replacing with
straightforward chains of promises.

This also harmonizes us with the new browser tests from kerl@, which
uses promises.

The next CL will try to get rid of the waitFor functions. Further CLs
will eliminate other use of the addExpectedEvent etc functions.

Bug:  735347 
Change-Id: Ibc6dd5ec15aed21fa7f52b7fcc83f5f4d12fe134
Reviewed-on: https://chromium-review.googlesource.com/747626
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514458}
[modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/getusermedia-depth-capture.html
[modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/getusermedia-real-webcam.html
[modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/getusermedia.html
[modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/peerconnection-call.html
[modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/video_capture_test.html
[modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/webrtc_test_utilities.js

Sign in to add a comment