New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735338 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Processes which request clean shutdown can hang

Project Member Reported by roc...@chromium.org, Jun 21 2017 
If clean shutdown is requested before all proxies are dissolved, and the final event which places the system in a proxy-free state is received over IPC (rather than via some process-local API call), shutdown will never be unblocked and the process will hang.

This does not affect any interesting processes in production Chrome, but can affect tests and services in non-production environments.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c58002d91c410e16c590816f0474c790effcd7b

commit 6c58002d91c410e16c590816f0474c790effcd7b
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Jun 21 18:22:45 2017

Mojo EDK: Fix clean shutdown

Though not used in production in any way that's affected by this,
r477744 broke clean shutdown. The bug is ultimately caused by the fact
that we don't check the shutdown-requested state after processing
incoming control event IPC, so if such an event is responsible for
making the system enter a clean-shutdownable state, it will go
undetected and the shutdown process will hang.

BUG= 735338 
TBR=jcivelli@chromium.org

Change-Id: If3ca2344a70024fbf6bc028ae177f23026612011
Reviewed-on: https://chromium-review.googlesource.com/543677
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481248}
[modify] https://crrev.com/6c58002d91c410e16c590816f0474c790effcd7b/mojo/edk/system/node_controller.cc

Comment 2 by roc...@chromium.org, Jun 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment