New issue
Advanced search Search tips

Issue 735332 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 510287



Sign in to add a comment

bluetooth: Fix add-multiple-event-listeners.html

Project Member Reported by ortuno@chromium.org, Jun 21 2017

Issue description

The following line is supposed to test that the two buffers have the same values but since they are not arrays the method doesn't test anything:

assert_array_equals(event_value, read_value);

We should change this to:

let read_value_arr = Array.from(new Uint8Array(read_value));
let event_value_arr = Array.from(new Uint8Array(event_value));

assert_array_equals(read_value_arr, event_values_arr);
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc3a88618e08e629c703fb225c28e3812d02e06

commit afc3a88618e08e629c703fb225c28e3812d02e06
Author: Sunny <ratsunny@gmail.com>
Date: Fri Jul 07 03:43:17 2017

Fix array equality test in add-multiple-event-listeners.html

|assert_array_equals| cannot assert the equality of two buffers,
convert them to normal array can fix it.

Bug:  735332 
Change-Id: I2a172cd8bf09f2ef1809a1b323af7e77c0d8083c
Reviewed-on: https://chromium-review.googlesource.com/547546
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484821}
[modify] https://crrev.com/afc3a88618e08e629c703fb225c28e3812d02e06/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/add-multiple-event-listeners.html
[modify] https://crrev.com/afc3a88618e08e629c703fb225c28e3812d02e06/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html
[modify] https://crrev.com/afc3a88618e08e629c703fb225c28e3812d02e06/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-succeeds.html
[modify] https://crrev.com/afc3a88618e08e629c703fb225c28e3812d02e06/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-updates-value.html
[modify] https://crrev.com/afc3a88618e08e629c703fb225c28e3812d02e06/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-updates-value.html

Status: Fixed (was: Available)

Sign in to add a comment