unknown field name "match_tag" in vpython.Spec_Package |
||||
Issue descriptionI was trying to run my third_party/WebKit/Tools/Scripts/merge-layout-test-results script and got the following error; ----------------------------------------------------------- $ third_party/WebKit/Tools/Scripts/merge-layout-test-results --verbose --allow-existing-output-directory --remove-existing-output-directory --output-directory=/fast/testdir2 blah blah [E2017-06-21T14:29:02.829101+10:00 153532 0 annotate.go:343] original error: line 23: unknown field name "match_tag" in vpython.Spec_Package [E2017-06-21T14:29:02.829173+10:00 153532 0 annotate.go:343] [E2017-06-21T14:29:02.829203+10:00 153532 0 annotate.go:343] goroutine 1: [E2017-06-21T14:29:02.829228+10:00 153532 0 annotate.go:343] #0 github.com/luci/luci-go/vpython/spec/load.go:64 - spec.Parse() [E2017-06-21T14:29:02.829258+10:00 153532 0 annotate.go:343] reason: "failed to unmarshal vpython.Spec" [E2017-06-21T14:29:02.829291+10:00 153532 0 annotate.go:343] [E2017-06-21T14:29:02.829316+10:00 153532 0 annotate.go:343] #1 github.com/luci/luci-go/vpython/spec/load.go:53 - spec.Load() [E2017-06-21T14:29:02.829340+10:00 153532 0 annotate.go:343] #2 github.com/luci/luci-go/vpython/spec/load.go:204 - spec.(*Loader).LoadForScript() [E2017-06-21T14:29:02.829364+10:00 153532 0 annotate.go:343] #3 github.com/luci/luci-go/vpython/options.go:133 - vpython.(*Options).ResolveSpec() [E2017-06-21T14:29:02.829387+10:00 153532 0 annotate.go:343] reason: "failed to load spec for script: {third_party/WebKit/Tools/Scripts/merge-layout-test-results}" [E2017-06-21T14:29:02.829411+10:00 153532 0 annotate.go:343] "isModule" = false [E2017-06-21T14:29:02.829438+10:00 153532 0 annotate.go:343] "path" = python.ScriptTarget{Path:"third_party/WebKit/Tools/Scripts/merge-layout-test-results"} [E2017-06-21T14:29:02.829470+10:00 153532 0 annotate.go:343] [E2017-06-21T14:29:02.829493+10:00 153532 0 annotate.go:343] #4 github.com/luci/luci-go/vpython/options.go:68 - vpython.(*Options).resolve() [E2017-06-21T14:29:02.829517+10:00 153532 0 annotate.go:343] reason: "failed to resolve Python script" [E2017-06-21T14:29:02.829540+10:00 153532 0 annotate.go:343] [E2017-06-21T14:29:02.829567+10:00 153532 0 annotate.go:343] #5 github.com/luci/luci-go/vpython/run.go:52 - vpython.Run() [E2017-06-21T14:29:02.829578+10:00 153532 0 annotate.go:343] reason: "could not resolve options" [E2017-06-21T14:29:02.829590+10:00 153532 0 annotate.go:343] [E2017-06-21T14:29:02.829600+10:00 153532 0 annotate.go:343] #6 github.com/luci/luci-go/vpython/application/application.go:208 - application.(*application).mainImpl() [E2017-06-21T14:29:02.829612+10:00 153532 0 annotate.go:343] #7 github.com/luci/luci-go/vpython/application/application.go:278 - application.(*Config).Main.func1() [E2017-06-21T14:29:02.829631+10:00 153532 0 annotate.go:343] #8 github.com/luci/luci-go/vpython/application/support.go:26 - application.run() [E2017-06-21T14:29:02.829646+10:00 153532 0 annotate.go:343] #9 github.com/luci/luci-go/vpython/application/application.go:279 - application.(*Config).Main() [E2017-06-21T14:29:02.829658+10:00 153532 0 annotate.go:343] #10 vpython/main.go:71 - main.mainImpl() [E2017-06-21T14:29:02.829669+10:00 153532 0 annotate.go:343] #11 vpython/main.go:77 - main.main() [E2017-06-21T14:29:02.829684+10:00 153532 0 annotate.go:343] #12 runtime/proc.go:185 - runtime.main() [E2017-06-21T14:29:02.829696+10:00 153532 0 annotate.go:343] #13 runtime/asm_amd64.s:2197 - runtime.goexit() ----------------------------------------------------------- I've yet to debug what is causing this, but it seems something to do with vpython.
,
Jun 21 2017
There seems to be a bunch of things which are concerning here about vpython; * It seems to be writing things into my home directory at .vpython_cipd_cache * It seems to be writing things into the depot_tools directory at /fast/chrome/depot_tools/.cipd_bin(/) * This download is being not being run as part of gclient sync * What would have happened if I was offline? * The logging messages don't indicate they are coming from vpython and not my program. * These logging messages could potentially interfere with the output of my program. IE Things would have been very confusing if I was running 'myprogram 2>&1 | head -n2' or similar.
,
Jun 21 2017
Those are all good points. Let me see if I can address them one-by-one: * It seems to be writing things into my home directory at .vpython_cipd_cache Gotta write them somewhere :) Other Chromium tools use home directory files for caching and staging, so this isn't really a deviation, and it is wholly encapsulated. If this is concerning, we should probably have a larger discussion about where user files that tools generate should reside. * It seems to be writing things into the depot_tools directory at /fast/chrome/depot_tools/.cipd_bin(/) This is actually just the "depot_tools" CIPD binary distribution wrapper: https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/cipd_bin_setup.sh vpython uses this because it's a binary. It runs once and caches, effectively creating the semblance of binaries being included in "depot_tools" while not actually checking them in. Which brings us to the next part... * This download is being not being run as part of gclient sync * What would have happened if I was offline? Great points. The right solution here is to add a "vpython -dev install" subcommand to runhooks so that the VirtualEnvs get initialized during checkout. This will seed by the CIPD binary wrapper and the VirtualEnv itself. * The logging messages don't indicate they are coming from vpython and not my program. * These logging messages could potentially interfere with the output of my program. IE Things would have been very confusing if I was running 'myprogram 2>&1 | head -n2' or similar. The logging is definitely gratuitous. The script that's calling "vpython" must be supplying "-log-level info". This behavior should only be employed if the user requests verbose output. OTOH it looks like you did ("--verbose"), so maybe this is exactly what the logic is doing. +qyearsley@ for feedback here.
,
Jun 22 2017
,
Jun 22 2018
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by tansell@chromium.org
, Jun 21 2017