Can't scroll omnibox suggestions |
||||
Issue descriptionChrome Version: Canary OS: Android What steps will reproduce the problem? (1) Select omnibox with Google Keyboard (2) Try to scroll to see 4th suggestion What is the expected result? See 4th suggestion What happens instead? It doesn't let me scroll to the 4th suggestion
,
Jun 23 2017
,
Jun 23 2017
Another case to test: What steps will reproduce the problem? (1) Switch phone to landscape (2) Tap into omnibox (3) Scroll down suggestions (4) Scroll up suggestions What is the expected result? Suggestions scroll up What happens instead? Chrome Home dismisses itself
,
Jun 29 2017
,
Jul 6 2017
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2cfd5c921e1c558f9a1922f62592e5032252a49 commit f2cfd5c921e1c558f9a1922f62592e5032252a49 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Jul 17 16:52:50 2017 [Home] Allow omnibox suggestions to be scrolled up Previously, omnibox suggestions could be scrolled down, but when scrolling back up, the bottom sheet would intercept the scroll and defocus the omnibox. This change adds a special case to the bottom sheet event handler. If the suggestions are showing and scrolled any amount, the sheet will not take the scroll event (unless it is in the toolbar area). This allows the suggestions to be freely scrolled and only when they reach the top can the sheet be pulled down. BUG= 735319 Change-Id: Icaf373d573b8c2380452d2b5e272aa1ed578f4ca Reviewed-on: https://chromium-review.googlesource.com/562667 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#487120} [modify] https://crrev.com/f2cfd5c921e1c558f9a1922f62592e5032252a49/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java [modify] https://crrev.com/f2cfd5c921e1c558f9a1922f62592e5032252a49/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/f2cfd5c921e1c558f9a1922f62592e5032252a49/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java [modify] https://crrev.com/f2cfd5c921e1c558f9a1922f62592e5032252a49/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
,
Jul 17 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by twelling...@chromium.org
, Jun 23 2017Owner: danielpark@chromium.org
Status: Assigned (was: Available)