New issue
Advanced search Search tips

Issue 735300 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Turn on timestamp printing for the log output of the swarming collection and merging script

Project Member Reported by tansell@chromium.org, Jun 21 2017

Issue description

Currently the collection and merging script outputs log lines like follows;
-------------
WARNING:root:task_output_dir '/tmp/tmpo30YKt' already exists!
WARNING:root:task_output_dir existing content: []
-------------

It would be much better if the script output log lines with a timestamp like follows;
-------------
16:17:00.863 WARNING:root:task_output_dir '/tmp/tmpo30YKt' already exists!
16:17:01.863 WARNING:root:task_output_dir existing content: []
-------------

It should also print a message for the start and end of each stage of the script.

This will allow us to understand how much time is going into waiting on the collect stage verses the merging stage.

 
Components: -Infra Infra>Platform>Swarming
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/270e8881098cc84fbacc014e4bc0387796beae47

commit 270e8881098cc84fbacc014e4bc0387796beae47
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Fri Jun 23 15:21:10 2017

swarming: Adding time to log messages in collect_task.py

This allows you to see how long collect verse merging is taking. It is
needed to figure out what is going on with  https://crbug.com/734467 

BUG= 524758 , 735300 , 734467 
R=qyearsley@chromium.org,jeffcarp@chromium.org,mcgreevy@chromium.org,dpranke@chromium.org,jbudorick@chromium.org

Change-Id: Ib8a440e65ea14e5eb79ff05f212846e6211642f8
Reviewed-on: https://chromium-review.googlesource.com/544752
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>

[modify] https://crrev.com/270e8881098cc84fbacc014e4bc0387796beae47/scripts/slave/recipe_modules/swarming/resources/collect_task.py

Comment 3 by mar...@chromium.org, Jun 21 2018

Cc: -mcgreevy@chromium.org
Components: -Infra>Platform>Swarming Infra>Platform>Swarming>Admin
Status: Fixed (was: Unconfirmed)

Sign in to add a comment