New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735297 link

Starred by 1 user
Status: Fixed
Owner:
█ tansell@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
qyears...@chromium.org
jeffcarp@chromium.org
█ mcgreevy@chromium.org
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Turn on timestamp printing for the log output of the merge-layout-test-results script

Project Member Reported by tansell@chromium.org, Jun 21 2017 
Currently the merge-layout-test-results script outputs log lines like follows;
-------------
webkitpy.layout_tests.merge_results: [DEBUG] Creating merged /b/rr/tmpQBh8cg/w/layout-test-results/webexposed/nonstable-css-properties-actual.txt from ['/tmp/tmpo30YKt/13/layout-test-results/webexposed/nonstable-css-properties-actual.txt']
webkitpy.layout_tests.merge_results: [DEBUG] Creating merged /b/rr/tmpQBh8cg/w/layout-test-results/webexposed/nonstable-css-properties-diff.txt from ['/tmp/tmpo30YKt/13/layout-test-results/webexposed/nonstable-css-properties-diff.txt']
webkitpy.layout_tests.merge_results: [DEBUG] Creating merged /b/rr/tmpQBh8cg/w/layout-test-results/webexposed/nonstable-css-properties-expected.txt from ['/tmp/tmpo30YKt/13/layout-test-results/webexposed/nonstable-css-properties-expected.txt']
webkitpy.layout_tests.merge_results: [DEBUG] Creating merged /b/rr/tmpQBh8cg/w/layout-test-results/webexposed/nonstable-css-properties-pretty-diff.html from ['/tmp/tmpo30YKt/13/layout-test-results/webexposed/nonstable-css-properties-pretty-diff.html']
webkitpy.layout_tests.merge_results: [DEBUG] Creating merged /b/rr/tmpQBh8cg/w/layout-test-results/webexposed/permissions-attribute-actual.txt from ['/tmp/tmpo30YKt/1/layout-test-results/webexposed/permissions-attribute-actual.txt']
webkitpy.layout_tests.merge_results: [DEBUG] Creating merged /b/rr/tmpQBh8cg/w/layout-test-results/webexposed/permissions-attribute-diff.txt from ['/tmp/tmpo30YKt/1/layout-test-results/webexposed/permissions-attribute-diff.txt']
-------------

It would be much better if the script output log lines with a timestamp in a manner similar to run-webkit-tests like follows;
-------------
16:21:12.616 21420 worker/7  renderer crashed
16:21:12.663 21411 worker/2 virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout.html passed
16:21:12.716 21415 worker/5 virtual/disable-spinvalidation/paint/invalidation/overflow-flipped-writing-mode-block.html failed:
16:21:12.716 21415 worker/5  text diff
-------------
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02a30eaf8b14d5f9d80f85470c0794ae584b12ff

commit 02a30eaf8b14d5f9d80f85470c0794ae584b12ff
Author: tansell <tansell@chromium.org>
Date: Sat Jun 24 07:18:32 2017

webkitpy: Add time output to the start of logging messages.

To understand how it is between log messages we should print a human
(and machine) parsable version of the current time.

This is needed to figure out what is going on in
 https://crbug.com/734467  but will be generally useful.

Before;
--------------------
webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled.
root: [DEBUG] results_json_value_overrides: {}
root: [WARNING] Output directory exists '/fast/testdir2'
webkitpy.common.system.filesystem: [INFO] Removing contents of /fast/testdir2
webkitpy.layout_tests.merge_results: [DEBUG] Merging following paths:
webkitpy.layout_tests.merge_results: [DEBUG] ['/fast/chrome/src/blah', '/fast/chrome/src/blah']
--------------------

After;
--------------------
2017-06-23 10:39:32,803 - webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled.
2017-06-23 10:39:32,803 - root: [DEBUG] results_json_value_overrides: {}
2017-06-23 10:39:32,804 - root: [WARNING] Output directory exists '/fast/testdir2'
2017-06-23 10:39:32,804 - webkitpy.common.system.filesystem: [INFO] Removing contents of /fast/testdir2
2017-06-23 10:39:32,805 - webkitpy.layout_tests.merge_results: [DEBUG] Merging following paths:
2017-06-23 10:39:32,805 - webkitpy.layout_tests.merge_results: [DEBUG] ['/fast/chrome/src/blah', '/fast/chrome/src/blah']
---------------------

R=qyearsley@chromium.org, jeffcarp@chromium.org, mcgreevy@chromium.org, dpranke@chromium.org
BUG= 735297 

Review-Url: https://codereview.chromium.org/2948043002
Cr-Commit-Position: refs/heads/master@{#482141}

[modify] https://crrev.com/02a30eaf8b14d5f9d80f85470c0794ae584b12ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/log_utils.py
[modify] https://crrev.com/02a30eaf8b14d5f9d80f85470c0794ae584b12ff/third_party/WebKit/Tools/Scripts/webkitpy/common/system/log_utils_unittest.py

Comment 2 by qyears...@chromium.org, Jul 17 2017

Owner: tansell@chromium.org
Status: Fixed (was: Unconfirmed)
I believe that this is now done.
►

Sign in to add a comment