ChromiumOS_x86 bot failing to compile ui/views/controls/button/checkbox.cc |
||||
Issue descriptionThe ChromiumOS_x86 bot is failing to compile: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FChromiumOS_x86-generic_Compile%2F36979%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile?numbuilds=200 This is a regression from: https://codereview.chromium.org/2939043005
,
Jun 21 2017
The second build error link is not related to my patch (it's in payment_method_view_controller.cc). It looks like the last patch to touch that file has already been reverted (https://chromium.googlesource.com/chromium/src/+/de503a07456be6c8c6b85deaa9559c4296a60d41). So I guess others are running into this problem too?
,
Jun 21 2017
There were two compile failures at the same time :/ First was payment_method_view_controller which has been fixed. Then, starting at build #36964, the failures start occurring in ui/views/controls/button/checkbox.cc. I think the latest failures are caused by your patch.
,
Jun 21 2017
I still think something is wrong with the builder; the unique_ptr upcasting pattern seems to work everywhere else and I can't reproduce the error locally. But I'll revert to green it for now.
,
Jun 21 2017
It's been reverted. stevenjb@: can you find someone to investigate whether it's a problem with the builder?
,
Jun 21 2017
This seems to be ready to leave the sheriff queue, because of the revert and assigned owner.
,
Jun 21 2017
We are aggressively deprecating this builder, it's a configuration we no longer support, so we can ignore this for now and resolve this as WontFix. (Tracking issue for deprecation is issue 735278 )
,
Jun 21 2017
We need to take this bot off the sheriff rotation / waterfall before we let patches land that break the bot.
,
Jun 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pdr@chromium.org
, Jun 21 2017