This was introduced in https://codereview.chromium.org/2940103003/ to have the pin keyboard's focus jump around without bringing up the VK. We should not need this after crbug.com/642513
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25 commit 0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25 Author: Sammie Quon <sammiequon@google.com> Date: Wed Jun 28 18:06:36 2017 lock: Remove ScopedKeyboardDisabler. This was a workaround to keep focus on the password element associated with the pin keyboard, but now that setTimeout(... focus(): ..., 0); works we do not need it anymore. Also some issues with focus on the setup pin keyboard in settings. Test: manual Bug: 735289 , 735290 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e167fc0a60e52090dd883a8a4eb3e21876f80a4 Reviewed-on: https://chromium-review.googlesource.com/542175 Reviewed-by: Biao She <bshe@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#483060} [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/resources/chromeos/quick_unlock/compiled_resources2.gyp [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.js [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/resources/settings/people_page/setup_pin_dialog.js [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/ui/keyboard/BUILD.gn [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/ui/keyboard/keyboard_util.cc [delete] https://crrev.com/894b62e67820e4a206b062ee39d13498cde3d6cd/ui/keyboard/scoped_keyboard_disabler.cc [delete] https://crrev.com/894b62e67820e4a206b062ee39d13498cde3d6cd/ui/keyboard/scoped_keyboard_disabler.h [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/0a29cb4bf60a59b0f52da3eb4ef88eec5b371d25/ui/login/account_picker/user_pod_row.js
Comment 1 by sammiequon@chromium.org
, Jun 21 2017