New issue
Advanced search Search tips

Issue 735288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Payments] Desktop: Fine-tune address/credit/contact editor behavior

Project Member Reported by ma...@chromium.org, Jun 21 2017

Issue description

If editing an item, the error labels should be shown in full, and not just the red outlines.
 
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfbee5bed65664da8b41975997b68af5922d2543

commit bfbee5bed65664da8b41975997b68af5922d2543
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Jun 28 18:48:20 2017

[Payments] Editor validation now runs when editing existing item.

Bug:  735288 
Test: browser_tests
Change-Id: Ic8fd7037e7a69a5038c41e54f52a9601a61e5a1f
Reviewed-on: https://chromium-review.googlesource.com/551182
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483079}
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/validating_combobox.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/validating_textfield.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/validating_textfield_unittest.cc
[modify] https://crrev.com/bfbee5bed65664da8b41975997b68af5922d2543/chrome/browser/ui/views/payments/validation_delegate.h

Comment 3 by ma...@chromium.org, Jun 29 2017

Status: Fixed (was: Started)

Sign in to add a comment