New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735261 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Traveling - Back 2/6
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
In-Product-Help


Sign in to add a comment

Track In-Product Help triggering as user actions

Project Member Reported by nyquist@chromium.org, Jun 20 2017

Issue description

Chrome Version: 60.0.3112.33, 61.0.3136.4
OS: Android

What steps will reproduce the problem?
(1) Enable finch experiment for In-Product Help
(2) Perform an action that could trigger In-Product Help
    A) IPH is triggered
    B) IPH is not triggered

What is the expected result?
Check UMA stats after a few days, and see that there are user actions for the 2A and 2B.

What happens instead?
Only a histogram containing 2A and 2B is logged.

Notes:
This would enable us to track CTR for when IPH is displayed and whether the user clicks what we suggest.
 
Components: Internals>FeatureEngagementTracker
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9bde1db3e7c27ff308166826a91ef9dc5cb5410

commit e9bde1db3e7c27ff308166826a91ef9dc5cb5410
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Thu Jun 22 17:57:07 2017

Add tracking of triggering result for In-Product Help

The FeatureEngagementTracker backend currently tracks the result of a
trigger-request as a histogram through SUCCESS and FAILURE (in
addition to the failure reason in the case of a failure).

However, that makes it hard to track whether the user did in fact
follow the guidelines and performed the expected action even though
that action is tracked, since there is no user action recorded
for if the triggering was successful, only for whether a triggering
might have occured.

This CL adds two more user actions; for when IPH triggered, and for
when it did not trigger.

BUG= 735261 

Change-Id: I65cc5f50c78ecb807feb467311b708d05a5dbcc6
Reviewed-on: https://chromium-review.googlesource.com/541923
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481596}
[modify] https://crrev.com/e9bde1db3e7c27ff308166826a91ef9dc5cb5410/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
[modify] https://crrev.com/e9bde1db3e7c27ff308166826a91ef9dc5cb5410/components/feature_engagement_tracker/internal/stats.cc
[modify] https://crrev.com/e9bde1db3e7c27ff308166826a91ef9dc5cb5410/tools/metrics/actions/actions.xml

Labels: Merge-Request-60
Status: Started (was: Untriaged)
Requesting merge of e9bde1db3e7c27ff308166826a91ef9dc5cb5410.
Will wait until we start seeing reports of this on canary before I merge.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 22 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Approved for M60 branch 3112.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 26 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78c0f7b0b9723782e74566be19293b2d51369910

commit 78c0f7b0b9723782e74566be19293b2d51369910
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Mon Jun 26 19:18:40 2017

Add tracking of triggering result for In-Product Help

The FeatureEngagementTracker backend currently tracks the result of a
trigger-request as a histogram through SUCCESS and FAILURE (in
addition to the failure reason in the case of a failure).

However, that makes it hard to track whether the user did in fact
follow the guidelines and performed the expected action even though
that action is tracked, since there is no user action recorded
for if the triggering was successful, only for whether a triggering
might have occured.

This CL adds two more user actions; for when IPH triggered, and for
when it did not trigger.

BUG= 735261 
TBR=nyquist@chromium.org

(cherry picked from commit e9bde1db3e7c27ff308166826a91ef9dc5cb5410)

Change-Id: I65cc5f50c78ecb807feb467311b708d05a5dbcc6
Reviewed-on: https://chromium-review.googlesource.com/541923
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#481596}
Reviewed-on: https://chromium-review.googlesource.com/549037
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#467}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/78c0f7b0b9723782e74566be19293b2d51369910/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc
[modify] https://crrev.com/78c0f7b0b9723782e74566be19293b2d51369910/components/feature_engagement_tracker/internal/stats.cc
[modify] https://crrev.com/78c0f7b0b9723782e74566be19293b2d51369910/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)

Sign in to add a comment