New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735245 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 20 2017

Issue description

"virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZgsSBUZsYWtlIlt2aXJ0dWFsL21vam8tbG9hZGluZy9odHRwL3Rlc3RzL2luc3BlY3Rvci9hcHBsaWNhdGlvbi1wYW5lbC9zdG9yYWdlLXZpZXctcmVwb3J0cy1xdW90YS5odG1sDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by vabr@chromium.org, Jun 21 2017

Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)
The test is timing out. Some tests with the virtual/mojo-loading/http/tests/inspector/ prefix, as well as http/tests/inspector/application-panel/storage-view-reports-quota.html are disabled and linked to bug 591099.

I am adding eae@, the owner of bug 591099 to help with routing this, and will be marking this test as possibly timing out.

Comment 2 by vabr@chromium.org, Jun 21 2017

Cc: e...@chromium.org
Components: Blink>Layout
Labels: -Sheriff-Chromium
Owner: ----
Status: Available (was: Assigned)
Now adding eae@ for real.
The disabling CL is https://chromium-review.googlesource.com/c/542857/, I'm removing this from the sheriff queue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9a41050a16713bc33277ead18ae0e4a6a4d06ea

commit c9a41050a16713bc33277ead18ae0e4a6a4d06ea
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Jun 21 10:47:14 2017

Mark virtual/.../storage-view-reports-quota.html as timing out flakily

Mark virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota.html as timing out flakily

BUG= 735245 
TBR=eae@chromium.org

Change-Id: Ic9df043e3a5d2de104dc3dec274cc9cc7c86f229
Reviewed-on: https://chromium-review.googlesource.com/542857
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481169}
[modify] https://crrev.com/c9a41050a16713bc33277ead18ae0e4a6a4d06ea/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

Comment 4 by e...@chromium.org, Jun 21 2017

Cc: -e...@chromium.org
Components: -Blink>Layout Blink>Loader
Status: Untriaged (was: Available)
Issue 591099 is about LayoutNG which is not on by default and isn't the cause here. Over to loading team for triage.

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/093dd5ab5f5fefa75e23e1d19731e8cf3eabebe2

commit 093dd5ab5f5fefa75e23e1d19731e8cf3eabebe2
Author: Nathan Bruer <allada@chromium.org>
Date: Thu Jun 22 02:38:05 2017

Mark storage-view-reports-quota.html as flakey

see title.

BUG= 735245 
TBR=eostroukhov

Change-Id: Ib6117e4fecdb84b1f680aa4dd6a0d66e1bf6fe10
Reviewed-on: https://chromium-review.googlesource.com/544496
Reviewed-by: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481412}
[modify] https://crrev.com/093dd5ab5f5fefa75e23e1d19731e8cf3eabebe2/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by allada@chromium.org, Jun 22 2017

Owner: eostroukhov@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by allada@chromium.org, Jun 22 2017

Cc: allada@chromium.org dgozman@chromium.org
 Issue 735906  has been merged into this issue.
Cc: yhirano@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cbfa47d81a26647e3d9af18bd40b821399ba9ca

commit 5cbfa47d81a26647e3d9af18bd40b821399ba9ca
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 05 05:34:41 2017

Delete outdated expectation for storage-view-reports-quota.html

TBR=eostroukhov@chromium.org

Bug:  735245 
Change-Id: Iead1b4094b2ffb947babbbac9ea478e669fa38bd
Reviewed-on: https://chromium-review.googlesource.com/649447
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499567}
[modify] https://crrev.com/5cbfa47d81a26647e3d9af18bd40b821399ba9ca/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/0ebd56da93abf970128804390879624b3dc79ac2/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ca6b720a0862855a42b23e59c1276e908a5a79f

commit 2ca6b720a0862855a42b23e59c1276e908a5a79f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 05 05:42:26 2017

Stop skipping some layout tests

We need test results for investigation

TBR=allada@chromium.org,eostroukhov@chromium.org

Bug:  735245 , 678481
Change-Id: I5cfb248a1527668efdf158d90f270a5e1b0f9a04
Reviewed-on: https://chromium-review.googlesource.com/650168
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499569}
[modify] https://crrev.com/2ca6b720a0862855a42b23e59c1276e908a5a79f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19355e514f6821aab5351709bf93ae1a77b6d1a6

commit 19355e514f6821aab5351709bf93ae1a77b6d1a6
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Sep 05 09:49:49 2017

Delete outdated expectation for storage-view-reports-quota.html

I should have deleted these files in [1].

1: https://chromium.googlesource.com/chromium/src/+/5cbfa47d81a26647e3d9af18bd40b821399ba9ca

Bug:  735245 
Change-Id: I84cd04cd7befb3db47195df75532cf14d2611137
Reviewed-on: https://chromium-review.googlesource.com/649590
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499593}
[delete] https://crrev.com/3e8074275acad6f5ed333a44a9b9fe09def7631a/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt
[delete] https://crrev.com/3e8074275acad6f5ed333a44a9b9fe09def7631a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt
[delete] https://crrev.com/3e8074275acad6f5ed333a44a9b9fe09def7631a/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt
[delete] https://crrev.com/3e8074275acad6f5ed333a44a9b9fe09def7631a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt
[delete] https://crrev.com/3e8074275acad6f5ed333a44a9b9fe09def7631a/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt
[delete] https://crrev.com/3e8074275acad6f5ed333a44a9b9fe09def7631a/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt
[delete] https://crrev.com/3e8074275acad6f5ed333a44a9b9fe09def7631a/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota-expected.txt

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd191553fdb24a4fe490cac85d3c356f0be8e92

commit ffd191553fdb24a4fe490cac85d3c356f0be8e92
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Sep 06 00:54:59 2017

Update layout test expectations for  crbug.com/735245 

The following tests
  virtual/mojo-loading/http/tests/inspector/application-panel/storage-view-reports-quota.html
  virtual/mojo-loading/http/tests/inspector/application-panel/resources-panel-resource-preview.html
failed on some mac try bots, e.g.:
https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_blink_rel/3861/layout-test-results/results.html

The failure result caused 'webkit-patch rebaseline-cl' to generate wrong
rebaselines in https://chromium-review.googlesource.com/c/chromium/src/+/648172/12
for the tests.

BUG= 735245 

Change-Id: I296bc70d85ae191536dd137625f85ded339d7f52
Reviewed-on: https://chromium-review.googlesource.com/650813
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499822}
[modify] https://crrev.com/ffd191553fdb24a4fe490cac85d3c356f0be8e92/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae5b8d6b6c53333e2ef66cc18f95d82d025e9a9

commit bae5b8d6b6c53333e2ef66cc18f95d82d025e9a9
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Sep 06 10:17:56 2017

Reorganize resources-panel-resource-preview.html expectation

Bug:  735245 ,  747751 
Change-Id: I0e0e07fffc7ffd258c7da6242f55016a5d48adfb
Reviewed-on: https://chromium-review.googlesource.com/651392
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499923}
[modify] https://crrev.com/bae5b8d6b6c53333e2ef66cc18f95d82d025e9a9/third_party/WebKit/LayoutTests/TestExpectations

Labels: Pri-3
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07078b417a290e317397275686f378c839c2887a

commit 07078b417a290e317397275686f378c839c2887a
Author: Will Chen <chenwilliam@chromium.org>
Date: Wed Jan 03 20:53:42 2018

DevTools: deflake http/tests/devtools/application-panel/storage-view-reports-quota.js

This test is occasionally timing out because it doesn't have enough time to finish. Many of its
successful runs are right below 6s (the threshold for timeout).

This reduces the test data for IndexedDB by over 100x so it should finish much faster
(~2x faster locally). It also cleans the usage value because it's platform-dependent.

Bug:  735245 
Change-Id: I2ed003becdc60bf4a35368403e91fa4f952fb2c3
Reviewed-on: https://chromium-review.googlesource.com/847912
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526800}
[modify] https://crrev.com/07078b417a290e317397275686f378c839c2887a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/07078b417a290e317397275686f378c839c2887a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/storage-view-reports-quota-expected.txt
[modify] https://crrev.com/07078b417a290e317397275686f378c839c2887a/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/storage-view-reports-quota.js

Owner: hhli@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment