New issue
Advanced search Search tips

Issue 735244 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add Printer Workflow: If no printers auto-discovered, display the manual printer setup dialog

Project Member Reported by weifangsun@chromium.org, Jun 20 2017

Issue description

When setting up a printer for CUPS (Settings -> Printers -> Add Printer), the default dialog should be "Add a nearby printer" via auto-discovery.

However, we should account for the case where no printers are available via auto-discovery - In this case, if 0 printers are detected, we should present the "Add a printer manually" to avoid presenting a dialog with an empty list of printers.
 
Note: We would like to make this update for M60 as auto-discovery specifically for USB connected printers has been enabled, but not general network auto-discovery. Therefore, the majority of printer setups will still need to be manual (when a printer is not plugged in).
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/007abfb715a7f00fb9d2d301626b5271940ad246

commit 007abfb715a7f00fb9d2d301626b5271940ad246
Author: xdai <xdai@chromium.org>
Date: Fri Jul 14 18:16:19 2017

[CUPS] If there is no auto-discovered printer, show the manual printer
setup dialog.

When setting up a printer for CUPS (Settings -> Printers -> Add Printer),
the default dialog should be "Add a nearby printer" via auto-discovery.

However, we should account for the case where no printers are available
via auto-discovery - In this case, if 0 printers are detected, we should
present the "Add a printer manually" to avoid presenting a dialog with an
empty list of printers.

BUG= 735244 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2979903003
Cr-Commit-Position: refs/heads/master@{#486811}

[modify] https://crrev.com/007abfb715a7f00fb9d2d301626b5271940ad246/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Comment 3 by x...@chromium.org, Jul 14 2017

Labels: Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 14 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Has this functionality been tested and released to dev?
I'm hesitant to bring this change this late in M60 

Comment 6 by x...@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)
I'll mark it as 'Fixed' to make it test on dev first.
Weifang, do we still want this change in M60 giving there is only a few days from stable cut?
Hmm, if we haven't yet been able to test this on Dev, I agree it's safer not to merge back to M60 given the stable release dates.
Labels: -M-60 -Merge-Review-60 Merge-Rejected-60 M-61
Updating target to M-61 

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment