Add Printer Workflow: If no printers auto-discovered, display the manual printer setup dialog |
||||||
Issue descriptionWhen setting up a printer for CUPS (Settings -> Printers -> Add Printer), the default dialog should be "Add a nearby printer" via auto-discovery. However, we should account for the case where no printers are available via auto-discovery - In this case, if 0 printers are detected, we should present the "Add a printer manually" to avoid presenting a dialog with an empty list of printers.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/007abfb715a7f00fb9d2d301626b5271940ad246 commit 007abfb715a7f00fb9d2d301626b5271940ad246 Author: xdai <xdai@chromium.org> Date: Fri Jul 14 18:16:19 2017 [CUPS] If there is no auto-discovered printer, show the manual printer setup dialog. When setting up a printer for CUPS (Settings -> Printers -> Add Printer), the default dialog should be "Add a nearby printer" via auto-discovery. However, we should account for the case where no printers are available via auto-discovery - In this case, if 0 printers are detected, we should present the "Add a printer manually" to avoid presenting a dialog with an empty list of printers. BUG= 735244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2979903003 Cr-Commit-Position: refs/heads/master@{#486811} [modify] https://crrev.com/007abfb715a7f00fb9d2d301626b5271940ad246/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
,
Jul 14 2017
,
Jul 14 2017
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 17 2017
Has this functionality been tested and released to dev? I'm hesitant to bring this change this late in M60
,
Jul 18 2017
I'll mark it as 'Fixed' to make it test on dev first. Weifang, do we still want this change in M60 giving there is only a few days from stable cut?
,
Jul 18 2017
Hmm, if we haven't yet been able to test this on Dev, I agree it's safer not to merge back to M60 given the stable release dates.
,
Jul 19 2017
Updating target to M-61
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by weifangsun@chromium.org
, Jun 20 2017