Issue metadata
Sign in to add a comment
|
Gerrit support for the manual merge drover workflow |
||||||||||||||||||||||
Issue descriptionI needed to merge a CL into a branch, and do manual changes to it. I followed the process at http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-drover.html but I used "git cl upload -gerrit" instead of "git cl upload". Initially, "git cl upload --gerrit" failed to upload the CL with the following output: remote: Processing changes: refs: 1, done remote: (W) 6c05b2b: commit subject >50 characters; use shorter first paragraph To https://chromium.googlesource.com/a/chromium/src.git ! [remote rejected] 6c05b2b98c7e3adfc99cd5ad0a8623346ba07a53 -> refs/for/refs/branch-heads/3112%m=Initial_upload,notify=NONE (change https://chromium-review.googlesource.com/540103 closed) error: failed to push some refs to 'https://chromium.googlesource.com/a/chromium/src.git' Error after CL description prompt -- saving description to /usr/local/google/home/costan/.git_cl_description_backup Failed to create a change. Please examine output above for the reason of the failure. Hint: run command below to diagnose common Git/Gerrit credential problems: git cl creds-check Per help from agable@, I worked around this problem by removing the Change-Id: header from the commit message. However, the manually merged CL does not point to the original CL, like git-drover's merged CL. Original CL: http://crrev.com/c/538965 Merged by git-drover: http://crrev.com/c/540103 Manual merge (with changes): http://crrev.com/c/541797 I can prepare a CL that documents the Change-Id: workaround. However, I don't know what's the right thing to do about the 2nd issue.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9756104b69447e418b55732e737f605cb1786069 commit 9756104b69447e418b55732e737f605cb1786069 Author: Aaron Gable <agable@chromium.org> Date: Wed Jun 21 16:42:58 2017 Document drover process for re-landing a CL in a release branch. BUG= 735230 Change-Id: Ia75170b3ea13c4c14eb7e8066ecb533f69adbc8d Reviewed-on: https://chromium-review.googlesource.com/542038 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9756104b69447e418b55732e737f605cb1786069/man/src/git-drover.txt [modify] https://crrev.com/9756104b69447e418b55732e737f605cb1786069/man/man1/git-drover.1 [modify] https://crrev.com/9756104b69447e418b55732e737f605cb1786069/man/man1/git-cl.1 [modify] https://crrev.com/9756104b69447e418b55732e737f605cb1786069/man/html/git-cl.html [modify] https://crrev.com/9756104b69447e418b55732e737f605cb1786069/man/html/git-drover.html
,
Jun 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aga...@chromium.org
, Jun 20 2017