New issue
Advanced search Search tips

Issue 735226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

vctip.exe leaks on buildbucket-luci.chromium.try-LUCI win_chromium_rel_ng

Project Member Reported by mar...@chromium.org, Jun 20 2017

Issue description

Sample failures:
https://chromium-swarm.appspot.com/task?id=36db17cdb7485d10&refresh=10&show_raw=1
https://chromium-swarm.appspot.com/task?id=36dc2b35b2338210&refresh=10&show_raw=1
https://chromium-swarm.appspot.com/task?id=36dd50d9d0c4b510&refresh=10&show_raw=1
https://chromium-swarm.appspot.com/task?id=36ded70ecb6c4310&refresh=10&show_raw=1

What happens is that vctip.exe process leaks and the Swarming bot has trouble removing the named cache because of this. Improving the named cache removal resiliency is tracked as  issue 735221 .

This issue is about not running vctip.exe ever as part of the recipe run.

 
vctip.exe is the "Microsoft® VC compiler and tools experience improvement data uploader" and it presumably runs automatically as part of running the compiler. We might be able to avoid this just by not packaging vctip.exe anymore - if it doesn't exist it can't be run. I don't know if that causes any problems, but I can try.

Comment 2 by mar...@chromium.org, Jun 21 2017

Cc: -brucedaw...@chromium.org
Owner: brucedaw...@chromium.org
Status: Assigned (was: Available)
Yes if you can repackage without this tool ASAP that would be *really* appreciated, as this process get stuck running in the background on the builders and makes it impossible to unmap the named cache (even if it's just a symlink) due to Windows file locking.

Thanks
Will do. Spot checking suggests that deleting vctip.exe doesn't cause any problems and should solve this issue.
Do we care about the "regression" for local devs using the toolchain not reporting bugs? I guess we'd rather have /fastfail real dumps anyway.
I've never noticed vctip.exe doing anything useful, but I'm not sure what I would look for. Do you think it has done anything for us?

Real crash dumps are generally going to be what I want anyway, so I think it doesn't matter.

Yup, sgtm.

I had the impression it was mostly for when the IDE hangs and they pop up that little thing that says they'll report it, but I don't actually know if that's true, or if there's any integration with cl/link. It seems odd that'd it be getting launched on the bots if neither cl nor link use it though.
The only time I've noticed vctip.exe before is when it was crashing, which is ironic. I'm not positive what triggers it but it's easy enough to package a new toolchain without it and see if it helps.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/b983ac1ae28165b738aa77ad56103312f0e0fc58

commit b983ac1ae28165b738aa77ad56103312f0e0fc58
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Thu Jun 22 17:31:04 2017

Update VC++ packaging script to not package vctip.exe

Some build machines end up running vctip.exe for some reason and then
it doesn't shut down in a timely manner, leaving locks on directories.
This changes the packaging script so that vctip.exe is not packaged, and
therefore won't be run.

vctip.exe is the "Microsoft VC compiler and tools experience
improvement data uploader" and it presumably runs automatically as part
of running the compiler. It's not clear what triggers it to run,
however omitting it should be safe.

BUG= 735226 

Change-Id: Ie6af562def6214a5bb130ccc09c732efc1769bcd
Reviewed-on: https://chromium-review.googlesource.com/544395
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/b983ac1ae28165b738aa77ad56103312f0e0fc58/win_toolchain/package_from_installed.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48c3f86f33b07d26c075b502ef6d0ba063c74bf3

commit 48c3f86f33b07d26c075b502ef6d0ba063c74bf3
Author: brucedawson <brucedawson@chromium.org>
Date: Thu Jun 22 17:40:42 2017

Updating VS 2015 package with no vctip.exe

This packages VS 2015 with vctip.exe removed in order to avoid problems
caused when it hangs around.

This is also packaged with a new Windows 10 SDK - 10.0.15063.468, which
fixes the header-file bugs that previously required patching.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

The process for creating this package is:
    - Install depot tools, run ‘gclient’, and add depot_tools to the path
    - Install final version of VS 2015 Professional Update 3 with these options:
     * Visual C++ and make sure the three nodes underneath are also selected
     * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" node is selected

Then the Windows 10.0.15063.468 SDK was installed, with all components.
This also installs the x86 and x64 debuggers.

Finally the packaging script (updated to filter out vctip.exe, with
https://chromium-review.googlesource.com/c/544395/) was run:

    python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.15063.0

This CL does *not* change build\toolchain\win\setup_toolchain.py to request
the 10.0.15063.0 SDK when building with DEPOT_TOOLS_WIN_TOOLCHAIN=0. That is
because this SDK is not yet required (crrev.com/2938543002 is a benign NOP
with the 14393 SDK).

BUG= 735226 

Review-Url: https://codereview.chromium.org/2950223002
Cr-Commit-Position: refs/heads/master@{#481586}

[modify] https://crrev.com/48c3f86f33b07d26c075b502ef6d0ba063c74bf3/build/vs_toolchain.py

Cc: mar...@chromium.org
Status: Fixed (was: Assigned)
This should be fixed. Can you please verify? Any builds starting after now should download the new toolchain package which does not have vctip.exe.
Thanks a lot for the quick fix! I'll revive and monitor 
https://chromium-swarm.appspot.com/bot?id=build115-m4&sort_stats=total%3Adesc
but everything should be fine.

Sign in to add a comment