New issue
Advanced search Search tips

Issue 735223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

v8 using undefined ast_id for mips

Project Member Reported by ntfschr@chromium.org, Jun 20 2017

Issue description

It looks like this may have been missed by https://chromium.googlesource.com/v8/v8.git/+/a42473abb7c80cada930a07168ad78a3ac394619

Our mips bot has a compile error: https://uberchromegw.corp.google.com/i/internal.client.clank/builders/mips-builder/builds/10352

Error looks like

-------------------------------------------------------
FAILED: obj/v8/v8_base/macro-assembler-mips.o 
/b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/v8/v8_base/macro-assembler-mips.o.d -DV8_DEPRECATION_WARNINGS -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"305735-1\" -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION_ROLL=r12b_1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__GNU_SOURCE=1 -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DENABLE_DISASSEMBLER -DOBJECT_PRINT -DVERIFY_HEAP -DV8_TRACE_MAPS -DV8_ENABLE_CHECKS -DV8_INTL_SUPPORT -DENABLE_HANDLE_ZAPPING -DV8_USE_SNAPSHOT -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_TARGET_ARCH_MIPS -DCAN_USE_FPU_INSTRUCTIONS -D__mips_hard_float=1 -DCAN_USE_FPU_INSTRUCTIONS -DFPU_MODE_FP32 -DDEBUG -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -I../.. -Igen -I../../v8 -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../v8/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -fcolor-diagnostics -ffunction-sections -fno-short-enums --target=mipsel-linux-android --target=mipsel-linux-android -march=mipsel -mcpu=mips32 -mhard-float -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -fno-omit-frame-pointer -gdwarf-3 -g1 --sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-mips -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wsign-compare -Winconsistent-missing-override -O2 -fno-ident -fdata-sections -ffunction-sections -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fno-exceptions -fvisibility-inlines-hidden -c ../../v8/src/mips/macro-assembler-mips.cc -o obj/v8/v8_base/macro-assembler-mips.o
../../v8/src/mips/macro-assembler-mips.cc:3999:35: error: use of undeclared identifier 'ast_id'
  DCHECK_EQ(CallSize(code, rmode, ast_id, cond, rs, rt, bd),
                                  ^
../../v8/src/mips/macro-assembler-mips.cc:3999:3: error: expected ')'
  DCHECK_EQ(CallSize(code, rmode, ast_id, cond, rs, rt, bd),
  ^
../../v8/src/base/logging.h:265:32: note: expanded from macro 'DCHECK_EQ'
#define DCHECK_EQ(v1, v2)      CHECK_EQ(v1, v2)
                               ^
../../v8/src/base/logging.h:246:28: note: expanded from macro 'CHECK_EQ'
#define CHECK_EQ(lhs, rhs) CHECK_OP(EQ, ==, lhs, rhs)
                           ^
../../v8/src/base/logging.h:64:72: note: expanded from macro 'CHECK_OP'
            ::v8::base::Check##name##Impl<decltype(lhs), decltype(rhs)>( \
                                                                       ^
../../v8/src/mips/macro-assembler-mips.cc:3999:3: note: to match this '('
../../v8/src/base/logging.h:265:32: note: expanded from macro 'DCHECK_EQ'
#define DCHECK_EQ(v1, v2)      CHECK_EQ(v1, v2)
                               ^
../../v8/src/base/logging.h:246:28: note: expanded from macro 'CHECK_EQ'
#define CHECK_EQ(lhs, rhs) CHECK_OP(EQ, ==, lhs, rhs)
                           ^
../../v8/src/base/logging.h:63:8: note: expanded from macro 'CHECK_OP'
    if (std::string* _msg =                                              \
       ^
2 errors generated.
-------------------------------------------------------

Assigning to mvstanton because his name came up for a `git log -Sast_id`. Please pass this bug back if it's not related. Thanks!
 
I think this is a bug on this dcheck [1]. I tried writing a change against v8 master branch, but it looks like this line has already changed. Could you please confirm that this issue will indeed be resolved once the commit rolls through?

[1] https://cs.chromium.org/chromium/src/v8/src/mips/macro-assembler-mips.cc?q=f:macro+f:v8+f:mips+f:cc+f:assemb&sq=package:chromium&dr&l=3999
It looks like the fix is in https://chromium.googlesource.com/v8/v8/+/932fd3ba9030d0fdb095ed284372f4b7b739128d

If that looks like it fixes everything, then let's close this once our bot goes green.
Status: Fixed (was: Assigned)
Apologies for missing that! My trybot only built mips release, so I missed it. Will be more careful next time...

Sign in to add a comment