New issue
Advanced search Search tips

Issue 735221 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Improve named cache removal resiliency

Project Member Reported by mar...@chromium.org, Jun 20 2017

Issue description

When one named cache removal fails (due to windows locking for example), the other named cached are not removed properly.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/8122a5d84198cd85ade442dbdcb4d3ef5ca2dc2c

commit 8122a5d84198cd85ade442dbdcb4d3ef5ca2dc2c
Author: maruel <maruel@chromium.org>
Date: Thu Jun 22 17:18:26 2017

Shuffle code around in file_path.

Eventually run_isolated needs to call kill_children_processes() when unlinking
named caches. This CL moves code around and changes what is public/private as a
preparation for this work but doesn't have functional changes.

Delete cleanup_path(), as it was unused.

R=vadimsh@chromium.org
BUG= 735221 

Review-Url: https://codereview.chromium.org/2949103004

[modify] https://crrev.com/8122a5d84198cd85ade442dbdcb4d3ef5ca2dc2c/client/utils/file_path.py

Comment 2 by mar...@chromium.org, Oct 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment