New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735211 link

Starred by 1 user
Status: Fixed
Owner:
█ pho...@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
akes...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Presence Metric is not repeated as it should be.

Project Member Reported by dgarr...@chromium.org, Jun 20 2017 
As can be seen by exploring this graph, we only appear to emit 'True' presence metrics for about three minutes, even if the build being metered lasts for hours.

http://shortn/_hKz87JsjLp


The Presence context manager can be found here:

https://cs.corp.google.com/chromeos_public/chromite/lib/metrics.py?rcl=e00808e4c8da9c088e61871495fe05a730974b23&l=331

The current usage of it can be found here:

https://cs.corp.google.com/chromeos_public/chromite/scripts/cbuildbot_launch.py?rcl=e00808e4c8da9c088e61871495fe05a730974b23&l=289

Comment 1 by pho...@chromium.org, Jun 20 2017

Status: Started (was: Untriaged)
Upon reflection, I think I know what's causing this; we wait indefinitely to .get() new messages in the metrics-sending process. If no new metrics come in, we don't Flush() the existing ones.

I think we should try to replicate this behavior in a unit or functional test, and change .get() to use a timeout, forcing a flush every 60s.

Comment 2 by pho...@chromium.org, Jul 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment