New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735186 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 744711
issue 767895



Sign in to add a comment

Surface data regarding swarmbucket tryjob performance in findit.

Project Member Reported by robert...@chromium.org, Jun 20 2017

Issue description

This task is meant to surface data that allows us to verify that migrating swarmbucket makes tryjobs be at least as fast as those running under buildbot.
 
Status: Started (was: Assigned)
Design discussion at https://docs.google.com/document/d/17elT0I7tOXsDoO1PdWWQBsYJmICa0mxN6H99OyJ1FC8/edit
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8d4465bab9f9e2c09a4606c8b5402cbf3b6146c3

commit 8d4465bab9f9e2c09a4606c8b5402cbf3b6146c3
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Jul 14 21:24:55 2017

[Findit] Add ui for swarmbucket_performance handler.

This change displays the information retrieved by the handler using a
simple table and a couple possible buttons per row.

If the swarmbucket tryjob has a matching buildbot job, the button allows
the user to compare the runs step by step, through a handler that is not
yet implemented. If it does not, a different button allows the user to
trigger such a job, also to a handler that needs to be implemented
still.

R=chanli,lijeffrey,wylieb
BUG=735186

Change-Id: If2dbc21481e43657db646ad8fe3da7ad1d7fba8b
Reviewed-on: https://chromium-review.googlesource.com/560782
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/8d4465bab9f9e2c09a4606c8b5402cbf3b6146c3/appengine/findit/handlers/test/swarmbucket_performance_test.py
[add] https://crrev.com/8d4465bab9f9e2c09a4606c8b5402cbf3b6146c3/appengine/findit/templates/swarmbucket_performance.html
[modify] https://crrev.com/8d4465bab9f9e2c09a4606c8b5402cbf3b6146c3/appengine/findit/handlers/swarmbucket_performance.py

Blocking: 744711
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b

commit f87811d2afd9f4da05b9f96b5f5c2c1c9028315b
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Jul 19 20:55:05 2017

[Findit] Handler to re-run a swarmbucket tryjob on legacy buildbot.

This is meant to provide performance data to ensure that migration to
swarmbucket does not regress.

The handler takes a url to a tryjob and triggers a run on buildbot using
the same parameters.

R=chanli,lijeffrey,wylieb
BUG=735186

Change-Id: I03b886a8e148699f6cc20f2e80c9dd3becb91abf
Reviewed-on: https://chromium-review.googlesource.com/575203
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[add] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/handlers/test/rerun_for_compare_test.py
[add] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/handlers/rerun_for_compare.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/waterfall/waterfall_config.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/handlers/swarmbucket_performance.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/waterfall/schedule_compile_try_job_pipeline.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/handlers/test/swarmbucket_performance_test.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/waterfall/schedule_try_job_pipeline.py
[modify] https://crrev.com/f87811d2afd9f4da05b9f96b5f5c2c1c9028315b/appengine/findit/waterfall/schedule_test_try_job_pipeline.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/466b67d4110462f8dda68d94a365b1e6b2414dfa

commit 466b67d4110462f8dda68d94a365b1e6b2414dfa
Author: Roberto Carrillo <robertocn@google.com>
Date: Mon Jul 24 20:11:26 2017

[Findit] Handler to compare two tryjob runs.

This handler is meant to be used by the swarmbucket performance page to
compare a buildbucket run vs a swarmbucket run stepb-by-step and help us
locate bottlenecks or needed optimizations.

R=chanli,lijeffrey,wylieb
BUG=735186

Change-Id: I193227c84570ec66c8516b45b825d7e455ef6c16
Reviewed-on: https://chromium-review.googlesource.com/571295
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[add] https://crrev.com/466b67d4110462f8dda68d94a365b1e6b2414dfa/appengine/findit/handlers/test/step_by_step_comparison_test.py
[modify] https://crrev.com/466b67d4110462f8dda68d94a365b1e6b2414dfa/appengine/findit/waterfall/test/buildbot_test.py
[modify] https://crrev.com/466b67d4110462f8dda68d94a365b1e6b2414dfa/appengine/findit/waterfall/buildbot.py
[modify] https://crrev.com/466b67d4110462f8dda68d94a365b1e6b2414dfa/appengine/findit/templates/swarmbucket_performance.html
[add] https://crrev.com/466b67d4110462f8dda68d94a365b1e6b2414dfa/appengine/findit/handlers/step_by_step_comparison.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/53466cc2c279f4ba1aa9bcaad3e62bceb0713b2b

commit 53466cc2c279f4ba1aa9bcaad3e62bceb0713b2b
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Jul 25 17:58:32 2017

[Findit] Enable swarmbucket performance page.

This change adds the handlers to main.py and also adds the entry to the
menu for admin users.

R=lijeffrey,chanli
BUG=735186

Change-Id: If4dec3a8a3fec1497f4429ee6d4b7dcee7ee18ff
Reviewed-on: https://chromium-review.googlesource.com/584107
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/53466cc2c279f4ba1aa9bcaad3e62bceb0713b2b/appengine/findit/main.py
[modify] https://crrev.com/53466cc2c279f4ba1aa9bcaad3e62bceb0713b2b/appengine/findit/ui/elements/findit-app.html

Status: Assigned (was: Started)
Blocking: 767895
Labels: -Pri-1 Pri-2

Sign in to add a comment