New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Support UMA sampling profiler collection beyond startup

Project Member Reported by asvitk...@chromium.org, Jun 20 2017

Issue description

Support UMA sampling profiler collection beyond startup.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d8b08c72cac89549268a67996c387323895ce22

commit 2d8b08c72cac89549268a67996c387323895ce22
Author: asvitkine <asvitkine@chromium.org>
Date: Fri Jul 14 22:16:00 2017

Make stack sampling profiler sample beyond startup.

This expands the base sampling profiler API to make the client callback to be able
to return new sampling params if another profiling collection should be started.

Additionally, converts sampling profiler reporting to use a base::Feature rather
than a field trial directly and adds a base::Feature param that specifies whether
this new functionality should be used to do periodic sampling (at 1s intervals). This
new functionality is not on by default, but can be enabled via a field trial.

The new periodic samples will be added to UMA logs as they're received and
will have PERIODIC_COLLECTION trigger specified in the proto.

Adds a test for the new base profiler functionality.

Also, updates profile_duration for non-periodic profiles to include the
sampling_period, as that was previously not accounted for.

Also fixes some existing lint warnings.

BUG= 735182 

Review-Url: https://codereview.chromium.org/2927593002
Cr-Commit-Position: refs/heads/master@{#486906}

[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/base/profiler/stack_sampling_profiler.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/base/profiler/stack_sampling_profiler.h
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/base/profiler/stack_sampling_profiler_unittest.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/base/time/time.h
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/chrome/browser/chrome_browser_main.h
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/BUILD.gn
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/call_stack_profile_collector.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/call_stack_profile_metrics_provider.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/call_stack_profile_metrics_provider.h
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/call_stack_profile_metrics_provider_unittest.cc
[delete] https://crrev.com/191d11489cb9f83e1e1575a29abf3904e7efa87b/components/metrics/call_stack_profile_params.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/call_stack_profile_params.h
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/child_call_stack_profile_collector.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/child_call_stack_profile_collector.h
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/child_call_stack_profile_collector_unittest.cc
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/public/cpp/call_stack_profile_struct_traits.h
[modify] https://crrev.com/2d8b08c72cac89549268a67996c387323895ce22/components/metrics/public/interfaces/call_stack_profile_collector.mojom

Labels: -OS-All M-63 OS-Mac OS-Windows
Marking as fixed - as this is now implemented for browser thread. We can file follow-up bugs for additional functionality.
Status: Fixed (was: Started)

Sign in to add a comment