New issue
Advanced search Search tips

Issue 735181 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Incorrect gerrit notification e-mails

Project Member Reported by e...@chromium.org, Jun 20 2017 
When gerrit sends an e-mail notification it sometimes sends multiple e-mails in the wrong order and with incorrect date fields.

This results in conversations with incorrect ordering and time stamps that do not match reality.

Take review 539460 for example.
https://chromium-review.googlesource.com/#/c/539460/

Patch set 3 was created at 12:49pm
The author set CQ+1 at 1:18pm
Patch set 4 was created at 1:18pm
I was added as a reviewer at 1:21pm

At 1:21pm I get an e-mail about being added as a reviwer. So far so good. Immediately following that I get replies to that e-mail (with a Reply-To header indicating the e-mail from 1:21pm) with back-dated timestamps.

This creates a very confusing and incorrect chronological representation. It also makes me *less* likely to do a review as it appears as a review is already in progress.
mailbug.png
72.1 KB View Download

Comment 1 by aga...@chromium.org, Jun 21 2017

Status: WontFix (was: Unconfirmed)
I'm gonna have to blame GMail and Google Groups for this one.

The emails were sent by Gerrit in the correct order. You would have received all of the emails (although some might have been filtered) because the emails sent before you were added as a reviewer were also going to blink-reviews@. My guess is that the roundtrip through the google group delayed their delivery to your inbox until after the message directly to you had already arrived, thus screwing up GMail's threading algorithm.

Unless the raw headers show those messages originating at the gerrit outbound endpoint out-of-order, I don't think this is Gerrit's fault.
►

Sign in to add a comment